Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 1377963004: Use FrameSelection::selectedText where possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check whether selection is range. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 086a79881696112c584d0d849db0724672006d89..c876c9e69278c8c0c58a31226d23dd6f2c7a0de4 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -1241,11 +1241,7 @@ WebString WebLocalFrameImpl::selectionAsText() const
if (pluginContainer)
return pluginContainer->plugin()->selectionAsText();
- const EphemeralRange range = frame()->selection().selection().toNormalizedEphemeralRange();
- if (range.isNull())
- return WebString();
-
- String text = plainText(range, TextIteratorEmitsObjectReplacementCharacter);
+ String text = frame()->selection().selectedText(TextIteratorEmitsObjectReplacementCharacter);
#if OS(WIN)
replaceNewlinesWithWindowsStyleNewlines(text);
#endif
@@ -1259,11 +1255,7 @@ WebString WebLocalFrameImpl::selectionAsMarkup() const
if (pluginContainer)
return pluginContainer->plugin()->selectionAsMarkup();
- const EphemeralRange range = frame()->selection().selection().toNormalizedEphemeralRange();
- if (range.isNull())
- return WebString();
-
- return createMarkup(range.startPosition(), range.endPosition(), AnnotateForInterchange, ConvertBlocksToInlines::NotConvert, ResolveNonLocalURLs);
+ return frame()->selection().selectedHTMLForClipboard();
}
void WebLocalFrameImpl::selectWordAroundPosition(LocalFrame* frame, VisiblePosition position)

Powered by Google App Engine
This is Rietveld 408576698