third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp - Issue 1377963004: Use FrameSelection::selectedText where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

Issue 1377963004: Use FrameSelection::selectedText where possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check whether selection is range. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp b/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

index 69c4a8318aa39f32b394c7b000264e0236600065..7f460d1cbd33193a2f5614bd94a902f82cca5996 100644

--- a/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

@@ -419,8 +419,7 @@ void TextFieldInputType::handleBeforeTextInsertedEvent(BeforeTextInsertedEvent*

// that case, and nothing in the text field will be removed.

unsigned selectionLength = 0;

if (element().focused()) {

- const VisibleSelection& selection = element().document().frame()->selection().selection();

- selectionLength = plainText(selection.toNormalizedEphemeralRange()).length();

+ selectionLength = element().document().frame()->selection().selectedText().length();

}

ASSERT(oldLength >= selectionLength);