Remove separate cache for clip mask textures

Remove separate cache for clip mask textures

Committed: https://skia.googlesource.com/skia/+/473addf17617d441edb44e501786cdd97d3ebdfb

[bsalomon, 2015-09-29 19:28:09]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2015-09-29 19:28:09]

Don't really want to land this until the branch, but might land and revert to
allow nanobench to run on it.

https://codereview.chromium.org/1377943003/diff/1/tests/ClipBoundsTest.cpp
File tests/ClipBoundsTest.cpp (right):

https://codereview.chromium.org/1377943003/diff/1/tests/ClipBoundsTest.cpp#ne...
tests/ClipBoundsTest.cpp:15: static const int X_SIZE = 12;
This is just the old ClipCacheTest.cpp with all the references to
GrClipMaskCache deleted.

[robertphillips, 2015-09-30 12:33:06]

lgtm + suggestions

https://codereview.chromium.org/1377943003/diff/1/src/gpu/GrClipMaskManager.cpp
File src/gpu/GrClipMaskManager.cpp (right):

https://codereview.chromium.org/1377943003/diff/1/src/gpu/GrClipMaskManager.c...
src/gpu/GrClipMaskManager.cpp:529: desc.fFlags = renderTarget ?
kRenderTarget_GrSurfaceFlag : kNone_GrSurfaceFlags;
Since we set fConfig to A8 by default, reverse the sense of this test, set
fConfig to 8888 and eliminate the else ?

https://codereview.chromium.org/1377943003/diff/1/tests/ClipBoundsTest.cpp
File tests/ClipBoundsTest.cpp (right):

https://codereview.chromium.org/1377943003/diff/1/tests/ClipBoundsTest.cpp#ne...
tests/ClipBoundsTest.cpp:1: /*
Should we update the date ?

https://codereview.chromium.org/1377943003/diff/1/tests/ClipBoundsTest.cpp#ne...
tests/ClipBoundsTest.cpp:19: // note: this is unused
Can we delete this then ?

https://codereview.chromium.org/1377943003/diff/1/tests/ClipBoundsTest.cpp#ne...
tests/ClipBoundsTest.cpp:54: 
Just SkAutoTUnref<GrTexture> texture( ... ?

https://codereview.chromium.org/1377943003/diff/1/tests/ClipBoundsTest.cpp#ne...
tests/ClipBoundsTest.cpp:62: SkIRect intScreen = SkIRect::MakeWH(kXSize,
kYSize);
SkRect screen = SkRect::Make(intScreen); ?

[bsalomon, 2015-09-30 19:59:40]

https://codereview.chromium.org/1377943003/diff/1/src/gpu/GrClipMaskManager.cpp
File src/gpu/GrClipMaskManager.cpp (right):

https://codereview.chromium.org/1377943003/diff/1/src/gpu/GrClipMaskManager.c...
src/gpu/GrClipMaskManager.cpp:529: desc.fFlags = renderTarget ?
kRenderTarget_GrSurfaceFlag : kNone_GrSurfaceFlags;
On 2015/09/30 12:33:05, robertphillips wrote:
> Since we set fConfig to A8 by default, reverse the sense of this test, set
> fConfig to 8888 and eliminate the else ?

Removed the default setting (meant to do that the first time).

https://codereview.chromium.org/1377943003/diff/1/tests/ClipBoundsTest.cpp
File tests/ClipBoundsTest.cpp (right):

https://codereview.chromium.org/1377943003/diff/1/tests/ClipBoundsTest.cpp#ne...
tests/ClipBoundsTest.cpp:1: /*
On 2015/09/30 12:33:06, robertphillips wrote:
> Should we update the date ?

Done.

https://codereview.chromium.org/1377943003/diff/1/tests/ClipBoundsTest.cpp#ne...
tests/ClipBoundsTest.cpp:19: // note: this is unused
On 2015/09/30 12:33:06, robertphillips wrote:
> Can we delete this then ?

Done, no idea why it was there.

https://codereview.chromium.org/1377943003/diff/1/tests/ClipBoundsTest.cpp#ne...
tests/ClipBoundsTest.cpp:62: SkIRect intScreen = SkIRect::MakeWH(kXSize,
kYSize);
On 2015/09/30 12:33:06, robertphillips wrote:
> SkRect screen = SkRect::Make(intScreen); ?

Done.

[bsalomon, 2015-09-30 19:59:57]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-09-30 19:59:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1377943003/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2015-09-30 20:00:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377943003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377943003/20001

[commit-bot: I haz the power, 2015-09-30 20:01:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-30 20:01:13]

Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)

[bsalomon, 2015-10-02 14:41:55]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-10-02 14:41:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1377943003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2015-10-02 14:42:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377943003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377943003/60001

[commit-bot: I haz the power, 2015-10-02 14:49:11]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/473addf17617d441edb44e501786cdd97d3ebdfb