chrome/test/data/extensions/api_test/management/management_policy/allowed.js - Issue 137793011: Require user confirmation for chrome.management.uninstall except when uninstalling self.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/management/management_policy/allowed.js

Issue 137793011: Require user confirmation for chrome.management.uninstall except when uninstalling self. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix ExtensionManagementApiBrowserTest.LaunchApp Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc ('k') | chrome/test/data/extensions/api_test/management/management_policy/prohibited.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/management/management_policy/allowed.js

diff --git a/chrome/test/data/extensions/api_test/management/management_policy/allowed.js b/chrome/test/data/extensions/api_test/management/management_policy/allowed.js

index 440a3c8bcffba2cabddccd5e770446216dc37179..cdd816882a1a1287ccaed63e96fd4569dd847480 100644

--- a/chrome/test/data/extensions/api_test/management/management_policy/allowed.js

+++ b/chrome/test/data/extensions/api_test/management/management_policy/allowed.js

@@ -64,10 +64,12 @@ var tests = [

chrome.test.assertEq(true, item.mayDisable);

var id = item.id;

- chrome.management.uninstall(id, callback(function() {

- chrome.test.assertNoLastError();

- // The calling api test will verify that the item was uninstalled.

- }));

+ chrome.test.runWithUserGesture(function() {

+ chrome.management.uninstall(id, callback(function() {

+ chrome.test.assertNoLastError();

+ // The calling api test will verify that the item was uninstalled.

+ }));

+ });

}));

}

];