Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 137783022: Revert of Add RGB565 Texture readback support in gl_helper (Closed)

Created:
6 years, 11 months ago by Mads Ager (chromium)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Add RGB565 Texture readback support in gl_helper (https://codereview.chromium.org/88033002/) Reason for revert: content_gl_tests failing on multiple gpu bots on the chromium.webkit buildbot. Example: http://chromegw.corp.google.com/i/chromium.webkit/builders/GPU%20Mac10.7/builds/19123 Original issue's description: > Add RGB565 Texture readback support in gl_helper > > Plan is to add a RGB565 readback and copy conversion for RGBA8 to RGB565 in GLHelper. > > BUG=323150 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245431 TBR=dtrainor@chromium.org,sievers@chromium.org,hubbe@chromium.org,aelias@chromium.org,piman@chromium.org,siva.gunturi@samsung.com NOTREECHECKS=true NOTRY=true BUG=323150 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245477

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -355 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/devtools/renderer_overrides_handler.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 7 chunks +6 lines, -24 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 6 chunks +2 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +1 line, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +1 line, -6 lines 0 comments Download
M content/common/gpu/client/gl_helper.h View 6 chunks +1 line, -10 lines 0 comments Download
M content/common/gpu/client/gl_helper.cc View 15 chunks +37 lines, -123 lines 0 comments Download
M content/common/gpu/client/gl_helper_benchmark.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/common/gpu/client/gl_helper_unittest.cc View 3 chunks +1 line, -137 lines 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/test_render_view_host.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
Created Revert of Add RGB565 Texture readback support in gl_helper
6 years, 11 months ago (2014-01-17 10:00:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/137783022/1
6 years, 11 months ago (2014-01-17 10:03:26 UTC) #2
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 10:09:40 UTC) #3
Message was sent while issue was closed.
Change committed as 245477

Powered by Google App Engine
This is Rietveld 408576698