telemetry: Pass correct objdump binary to perf

telemetry: Pass correct objdump binary to perf

Use the --objdump argument to point perf to the correct ARM objdump
binary so that it can properly annotate source code. Since this requires
a fairly new version of perf (3.10), don't add the argument to the
default set of perf options but rather just print a hint.

See http://www.chromium.org/developers/telemetry/profiling for
instructions on how to get a newer version of perf.

NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245241

[Sami, 2014-01-16 12:09:03]

Hey Marcus, do you know if there's a way to get the currently used toolchain?

[bulach, 2014-01-16 12:25:20]

lgtm, just nits. thanks!!

https://codereview.chromium.org/137783020/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py (right):

https://codereview.chromium.org/137783020/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py:81:
objdump_path = os.path.join(util.GetChromiumSrcDir(), 'third_party',
os.path.join(
    os.env.get('ANDROID_TOOLCHAIN',
               os.path.join(...)),
    'arm-linux-androideabi-objdump')

https://codereview.chromium.org/137783020/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py:86: print 'If
you have recent version of perf (3.10+), append the following '
this looks neat! mind adding instructions on how to install it in
http://www.chromium.org/developers/telemetry/profiling ?

[Sami, 2014-01-16 13:32:52]

https://codereview.chromium.org/137783020/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py (right):

https://codereview.chromium.org/137783020/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py:81:
objdump_path = os.path.join(util.GetChromiumSrcDir(), 'third_party',
On 2014/01/16 12:25:21, bulach wrote:
> os.path.join(
>     os.env.get('ANDROID_TOOLCHAIN',
>                os.path.join(...)),
>     'arm-linux-androideabi-objdump')

Ohh, fancy :) Thanks!

https://codereview.chromium.org/137783020/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py:86: print 'If
you have recent version of perf (3.10+), append the following '
On 2014/01/16 12:25:21, bulach wrote:
> this looks neat! mind adding instructions on how to install it in
> http://www.chromium.org/developers/telemetry/profiling ?

Good idea, done!

[commit-bot: I haz the power, 2014-01-16 13:33:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skyostil@chromium.org/137783020/60001

[commit-bot: I haz the power, 2014-01-16 17:35:08]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2014-01-16 17:41:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skyostil@chromium.org/137783020/60001

[commit-bot: I haz the power, 2014-01-16 17:59:38]

Change committed as 245241