Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py

Issue 137783020: telemetry: Pass correct objdump binary to perf (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Look up toolchain dynamically. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py
diff --git a/tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py
index 97c6dbc28369a29fbd8c6101b64b8a5b2ed45f99..284da450c2c90624668bcc2440b124fc7bb2570d 100644
--- a/tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py
+++ b/tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py
@@ -77,6 +77,12 @@ Try rerunning this script under sudo or setting
if self._is_android:
print 'On Android, assuming $CHROMIUM_OUT_DIR/Release/lib has a fresh'
print 'symbolized library matching the one on device.'
+ objdump_path = os.path.join(os.environ.get('ANDROID_TOOLCHAIN',
+ '$ANDROID_TOOLCHAIN'),
+ 'arm-linux-androideabi-objdump')
+ print 'If you have recent version of perf (3.10+), append the following '
+ print 'to see annotated source code (by pressing the \'a\' key): '
+ print ' --objdump %s' % objdump_path
cmd += ' ' + ' '.join(self._PrepareAndroidSymfs())
print 'To view the profile, run:'
print ' ', cmd
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698