Issue 137783015: Merge 244538 "Don't populate URL data in WebDropData when draggi..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137783015: Merge 244538 "Don't populate URL data in WebDropData when draggi..." (Closed)

Created:
6 years, 11 months ago by dcheng

Modified:
6 years, 11 months ago

Reviewers:
dcheng

CC:
chromium-reviews, browser-components-watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, tfarina, James Su

Base URL:
svn://svn.chromium.org/chrome/branches/1750/src/

Visibility:
Public.

More Reviews

Description

Merge 244538 "Don't populate URL data in WebDropData when draggi..." > Don't populate URL data in WebDropData when dragging files. > > This is considered a potential security issue as well, since it leaks > filesystem paths. > > BUG=332579 > > Review URL: https://codereview.chromium.org/135633002 TBR=dcheng@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245053

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -23 lines)			Patch
M	chrome/browser/bookmarks/bookmark_node_data_unittest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_node_data_views.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_root_view.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_view_views.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_strip.cc	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/toolbar/home_button.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_view_aura.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/base/dragdrop/os_exchange_data.h	View	3 chunks	+10 lines, -2 lines	0 comments	Download
M	ui/base/dragdrop/os_exchange_data.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	ui/base/dragdrop/os_exchange_data_provider_aura.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	ui/base/dragdrop/os_exchange_data_provider_aura.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	ui/base/dragdrop/os_exchange_data_provider_aurax11.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/base/dragdrop/os_exchange_data_provider_aurax11_unittest.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	ui/base/dragdrop/os_exchange_data_provider_win.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	ui/base/dragdrop/os_exchange_data_provider_win.cc	View	1 chunk	+9 lines, -3 lines	0 comments	Download
M	ui/base/dragdrop/os_exchange_data_unittest.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r245053.

Expand Messages | Collapse Messages