Don't populate URL data in WebDropData when dragging files.

Don't populate URL data in WebDropData when dragging files.

This is considered a potential security issue as well, since it leaks
filesystem paths.

BUG=332579
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244538

[dcheng, 2014-01-11 19:08:16]

I'm pretty sure that this is what's causing the extra entry to show up.

[dcheng, 2014-01-11 19:08:44]

(Hit send too early. The caveat is I haven't actually tested the patch to make
sure it resolves the issue since I don't have access to a Windows machine atm)

[scottmg, 2014-01-11 23:12:38]

On 2014/01/11 19:08:44, dcheng wrote:
> (Hit send too early. The caveat is I haven't actually tested the patch to make
> sure it resolves the issue since I don't have access to a Windows machine atm)

It seems reasonable to me, but I still can't drop files from explorer on local
builds (it works fine in today's Canary so must be something to do with my local
build). Haven't had a chance to start debugging that today ... so I'm not sure
if this helps yet, sorry.

[dcheng, 2014-01-12 23:52:05]

On 2014/01/11 23:12:38, scottmg wrote:
> On 2014/01/11 19:08:44, dcheng wrote:
> > (Hit send too early. The caveat is I haven't actually tested the patch to
make
> > sure it resolves the issue since I don't have access to a Windows machine
atm)
> 
> It seems reasonable to me, but I still can't drop files from explorer on local
> builds (it works fine in today's Canary so must be something to do with my
local
> build). Haven't had a chance to start debugging that today ... so I'm not sure
> if this helps yet, sorry.

I've patched it in and confirmed that it fixes the issue described. It took
awhile because I ran into http://crbug.com/308740

[scottmg, 2014-01-13 04:04:03]

Thanks for looking into this Daniel. I'm not a qualified reviewer (or OWNER), so
adding sky.

[sky, 2014-01-13 15:13:45]

https://codereview.chromium.org/135633002/diff/120001/ui/base/dragdrop/os_exc...
File ui/base/dragdrop/os_exchange_data.h (right):

https://codereview.chromium.org/135633002/diff/120001/ui/base/dragdrop/os_exc...
ui/base/dragdrop/os_exchange_data.h:72: ConvertFilenames,
Style guide says enum values should be ALL_CAPS (as Format is above). And you
need descriptions.

[dcheng, 2014-01-13 15:49:26]

https://codereview.chromium.org/135633002/diff/120001/ui/base/dragdrop/os_exc...
File ui/base/dragdrop/os_exchange_data.h (right):

https://codereview.chromium.org/135633002/diff/120001/ui/base/dragdrop/os_exc...
ui/base/dragdrop/os_exchange_data.h:72: ConvertFilenames,
On 2014/01/13 15:13:45, sky wrote:
> Style guide says enum values should be ALL_CAPS (as Format is above). And you
> need descriptions.

Oops... I've been off in Blink a bit too long. Fixed.

[sky, 2014-01-13 16:22:02]

LGTM

[commit-bot: I haz the power, 2014-01-13 16:28:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/135633002/240001

[commit-bot: I haz the power, 2014-01-13 18:22:25]

Change committed as 244538