Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1377813002: Oilpan: fix build after r351269. (Closed)

Created:
5 years, 2 months ago by sof
Modified:
5 years, 2 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: fix build after r351269. R=haraken BUG=439376 Committed: https://crrev.com/035e58eff2c08c2acf734265d58bf24db976c288 Cr-Commit-Position: refs/heads/master@{#351325}

Patch Set 1 #

Patch Set 2 : (plenty) more fixes needed #

Patch Set 3 : Pull V8DebuggerAgentImpl off the heap also ++ #

Total comments: 1

Patch Set 4 : use a WeakPersistent<InjectedScriptManager> instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -81 lines) Patch
M third_party/WebKit/Source/core/inspector/AsyncCallChain.h View 1 2 2 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/AsyncCallChain.cpp View 1 2 2 chunks +3 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/AsyncCallTracker.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/AsyncCallTracker.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/AsyncOperationMap.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InjectedScriptHost.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InjectedScriptHost.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/PromiseTracker.h View 1 2 4 chunks +8 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PromiseTracker.cpp View 1 2 4 chunks +1 line, -14 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8AsyncCallTracker.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8AsyncCallTracker.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h View 1 2 3 3 chunks +7 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp View 1 2 4 chunks +4 lines, -15 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
sof
5 years, 2 months ago (2015-09-29 11:59:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377813002/20001
5 years, 2 months ago (2015-09-29 11:59:56 UTC) #3
sof
Unchecked; there is something quite wrong here still wrt V8DebuggerAgent and V8DebuggerAgentImpl.
5 years, 2 months ago (2015-09-29 12:02:47 UTC) #5
sof
On 2015/09/29 12:02:47, sof wrote: > Unchecked; there is something quite wrong here still wrt ...
5 years, 2 months ago (2015-09-29 12:48:02 UTC) #6
haraken
On 2015/09/29 12:48:02, sof wrote: > On 2015/09/29 12:02:47, sof wrote: > > Unchecked; there ...
5 years, 2 months ago (2015-09-29 12:58:15 UTC) #7
sof
https://codereview.chromium.org/1377813002/diff/40001/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h (right): https://codereview.chromium.org/1377813002/diff/40001/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h#newcode195 third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h:195: RawPtrWillBePersistent<InjectedScriptManager> m_injectedScriptManager; This needs to be a WeakPersistent<> so ...
5 years, 2 months ago (2015-09-29 13:03:05 UTC) #8
sof
On 2015/09/29 12:58:15, haraken wrote: > On 2015/09/29 12:48:02, sof wrote: > > On 2015/09/29 ...
5 years, 2 months ago (2015-09-29 13:04:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377813002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377813002/60001
5 years, 2 months ago (2015-09-29 13:04:48 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-09-29 15:59:22 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 16:00:24 UTC) #14
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/035e58eff2c08c2acf734265d58bf24db976c288
Cr-Commit-Position: refs/heads/master@{#351325}

Powered by Google App Engine
This is Rietveld 408576698