Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp

Issue 1377813002: Oilpan: fix build after r351269. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use a WeakPersistent<InjectedScriptManager> instead Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp
diff --git a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp
index bc253cfb9f90c8e8c1a8375ad6796549db2d3683..c5c45f00653ddd047346ea305bfd932fe06de8df 100644
--- a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp
+++ b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp
@@ -167,17 +167,6 @@ V8DebuggerAgentImpl::~V8DebuggerAgentImpl()
{
}
-DEFINE_TRACE(V8DebuggerAgentImpl)
-{
-#if ENABLE(OILPAN)
- visitor->trace(m_injectedScriptManager);
- visitor->trace(m_v8AsyncCallTracker);
- visitor->trace(m_promiseTracker);
- visitor->trace(m_asyncOperations);
- visitor->trace(m_currentAsyncCallChain);
-#endif
-}
-
bool V8DebuggerAgentImpl::checkEnabled(ErrorString* errorString)
{
if (enabled())
@@ -890,7 +879,7 @@ bool V8DebuggerAgentImpl::callStackForId(ErrorString* errorString, const RemoteC
*errorString = "Async call stack not found";
return false;
}
- RefPtrWillBeRawPtr<AsyncCallStack> asyncStack = m_currentAsyncCallChain->callStacks()[asyncOrdinal - 1];
+ RefPtr<AsyncCallStack> asyncStack = m_currentAsyncCallChain->callStacks()[asyncOrdinal - 1];
*callStack = asyncStack->callFrames(m_isolate);
*isAsync = true;
return true;
@@ -1144,12 +1133,12 @@ int V8DebuggerAgentImpl::traceAsyncOperationStarting(const String& description)
{
v8::HandleScope scope(m_isolate);
v8::Local<v8::Object> callFrames = debugger().currentCallFramesForAsyncStack();
- RefPtrWillBeRawPtr<AsyncCallChain> chain = nullptr;
+ RefPtr<AsyncCallChain> chain;
if (callFrames.IsEmpty()) {
if (m_currentAsyncCallChain)
chain = AsyncCallChain::create(nullptr, m_currentAsyncCallChain.get(), m_maxAsyncCallStackDepth);
} else {
- chain = AsyncCallChain::create(adoptRefWillBeNoop(new AsyncCallStack(description, callFrames)), m_currentAsyncCallChain.get(), m_maxAsyncCallStackDepth);
+ chain = AsyncCallChain::create(adoptRef(new AsyncCallStack(description, callFrames)), m_currentAsyncCallChain.get(), m_maxAsyncCallStackDepth);
}
do {
++m_lastAsyncOperationId;
@@ -1269,7 +1258,7 @@ void V8DebuggerAgentImpl::flushAsyncOperationEvents(ErrorString*)
return;
for (int operationId : m_asyncOperationNotifications) {
- RefPtrWillBeRawPtr<AsyncCallChain> chain = m_asyncOperations.get(operationId);
+ RefPtr<AsyncCallChain> chain = m_asyncOperations.get(operationId);
ASSERT(chain);
const AsyncCallStackVector& callStacks = chain->callStacks();
ASSERT(!callStacks.isEmpty());
« no previous file with comments | « third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698