Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 1377713002: optimize-ico-files: Move the logic for this script into a module. (Closed)

Created:
5 years, 2 months ago by Matt Giuca
Modified:
5 years, 2 months ago
Reviewers:
oshima
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@optimize-ico-files-fixmasks
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

optimize-ico-files: Move the logic for this script into a module. This creates the Python module icon_tools.py. This is so that we can call the module from a PRESUBMIT script in the future. BUG=534679 Committed: https://crrev.com/0e97ba4a3a44642d1eb8c37e00fc1e35bad3045d Cr-Commit-Position: refs/heads/master@{#353621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -253 lines) Patch
A + tools/resources/ico_tools.py View 2 chunks +0 lines, -58 lines 0 comments Download
M tools/resources/optimize-ico-files.py View 2 chunks +2 lines, -195 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Matt Giuca
Continuing work on the ico tools towards a PRESUBMIT script.
5 years, 2 months ago (2015-10-12 02:40:55 UTC) #3
oshima
lgtm
5 years, 2 months ago (2015-10-12 20:27:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377713002/1
5 years, 2 months ago (2015-10-12 23:04:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 23:18:36 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 23:19:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e97ba4a3a44642d1eb8c37e00fc1e35bad3045d
Cr-Commit-Position: refs/heads/master@{#353621}

Powered by Google App Engine
This is Rietveld 408576698