Add a PRESUBMIT check for broken .ico files.

Add a PRESUBMIT check for broken .ico files.

This is in reaction to crbug.com/526622, where the Chrome .ico files
had a bad mask, making them render incorrectly on Windows. The presubmit
now checks that icons have a properly formed mask, as well as that the
large image is a compressed PNG (not an uncompressed BMP).

Also adds a --lint argument to the optimize-ico-files script that
manually runs the same checks on a given .ico file.

BUG=534679
Committed: https://crrev.com/e56b0cf9ec1e78b04c254405643c7a74380be168
Cr-Commit-Position: refs/heads/master@{#430777}

[Matt Giuca, 2015-10-12 02:39:33]

Patchset #2 (id:20001) has been deleted

[Matt Giuca, 2016-01-07 02:24:19]

Patchset #2 (id:40001) has been deleted

[Matt Giuca, 2016-11-07 06:33:55]

Patchset #2 (id:60001) has been deleted

[Matt Giuca, 2016-11-07 06:35:17]

mgiuca@chromium.org changed reviewers:
+ oshima@chromium.org, scottmg@chromium.org

[Matt Giuca, 2016-11-07 06:35:17]

As with the previous CL, I wrote this a year ago and I don't know why it was
never mailed out.

I tested this against a number of "bad" icon files I had from the time (when I
was dealing with some bad Chrome .ico files that were committed into the repo)
and it correctly points out their errors. Oshima at the time suggested adding a
presubmit check.

[scottmg, 2016-11-07 18:36:53]

lgtm

[oshima, 2016-11-08 17:48:16]

lgtm

https://codereview.chromium.org/1372113003/diff/80001/ui/resources/resource_c...
File ui/resources/resource_check/ico_files.py (right):

https://codereview.chromium.org/1372113003/diff/80001/ui/resources/resource_c...
ui/resources/resource_check/ico_files.py:1: # Copyright 2015 The Chromium
Authors. All rights reserved.
nit: 2016

[Matt Giuca, 2016-11-08 23:15:56]

https://codereview.chromium.org/1372113003/diff/80001/ui/resources/resource_c...
File ui/resources/resource_check/ico_files.py (right):

https://codereview.chromium.org/1372113003/diff/80001/ui/resources/resource_c...
ui/resources/resource_check/ico_files.py:1: # Copyright 2015 The Chromium
Authors. All rights reserved.
On 2016/11/08 17:48:16, oshima wrote:
> nit: 2016

Done.

[Matt Giuca, 2016-11-08 23:16:24]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-11-08 23:16:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
scottmg@chromium.org, oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1372113003/#ps100001
(title: "Update copyright year.")

[commit-bot: I haz the power, 2016-11-08 23:17:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 00:04:15]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-11-09 00:08:19]

Description was changed from

==========
Add a PRESUBMIT check for broken .ico files.

This is in reaction to crbug.com/526622, where the Chrome .ico files
had a bad mask, making them render incorrectly on Windows. The presubmit
now checks that icons have a properly formed mask, as well as that the
large image is a compressed PNG (not an uncompressed BMP).

Also adds a --lint argument to the optimize-ico-files script that
manually runs the same checks on a given .ico file.

BUG=534679
==========

to

==========
Add a PRESUBMIT check for broken .ico files.

This is in reaction to crbug.com/526622, where the Chrome .ico files
had a bad mask, making them render incorrectly on Windows. The presubmit
now checks that icons have a properly formed mask, as well as that the
large image is a compressed PNG (not an uncompressed BMP).

Also adds a --lint argument to the optimize-ico-files script that
manually runs the same checks on a given .ico file.

BUG=534679

Committed: https://crrev.com/e56b0cf9ec1e78b04c254405643c7a74380be168
Cr-Commit-Position: refs/heads/master@{#430777}
==========

[commit-bot: I haz the power, 2016-11-09 00:08:20]

Patchset 3 (id:??) landed as
https://crrev.com/e56b0cf9ec1e78b04c254405643c7a74380be168
Cr-Commit-Position: refs/heads/master@{#430777}