third_party/WebKit/Source/core/html/HTMLInputElement.cpp - Issue 1377673002: Properly fix use-after-free of InputTypeViews when the type attribute is modified in the change eve…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 1377673002: Properly fix use-after-free of InputTypeViews when the type attribute is modified in the change eve… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

index f06fd168e0d0d868defdd631efbfcad12c09c578..8beafdc24f696395c503d4b3e4660597544362a2 100644

--- a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

@@ -1181,6 +1181,8 @@ void HTMLInputElement::postDispatchEventHandler(Event* event, void* dataFromPreD

OwnPtrWillBeRawPtr<ClickHandlingState> state = adoptPtrWillBeNoop(static_cast<ClickHandlingState*>(dataFromPreDispatch));

if (!state)

return;

+ // m_inputTypeView could be freed if the type attribute is modified through a change event handler.

+ RefPtrWillBeRawPtr<InputTypeView> protect(m_inputTypeView);

m_inputTypeView->didDispatchClick(event, *state);

}

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/forms/CheckboxInputType.cpp » ('j') | no next file with comments »