Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1377453003: Revert of chromium_tests: raise infra failure when no compile targets are specified (Closed)

Created:
5 years, 2 months ago by Nico
Modified:
5 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org, Nico
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of chromium_tests: raise infra failure when no compile targets are specified (patchset #1 id:1 of https://codereview.chromium.org/1376453002/ ) Reason for revert: This is not a valid assumption, e.g. the clang bots all use the empty compile target as build target and were all broken with this. (As discussed previously, even!) Original issue's description: > chromium_tests: raise infra failure when no compile targets are specified > > This relies on default compile targets either on the recipe side or ninja, > but breaks badly with e.g. analyze. We're trying to make as much of bot > config explicit as possible. > > BUG=536186 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296903 TBR=tandrii@chromium.org,sergiyb@chromium.org,hans@chromium.org,phajdan.jr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=536186

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4015 lines, -143 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/api.py View 1 chunk +0 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm64_Builder__dbg_.json View 1 chunk +41 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm_Builder__dbg_.json View 1 chunk +41 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux.json View 1 chunk +21 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux_x64.json View 1 chunk +21 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Mac.json View 1 chunk +41 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Win.json View 1 chunk +22 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CFI_Linux.json View 1 chunk +38 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_10.json View 1 chunk +40 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Win_10.json View 1 chunk +20 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTAndroidASan.json View 1 chunk +77 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinux.json View 1 chunk +143 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxASan.json View 1 chunk +143 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinux__dbg_.json View 1 chunk +94 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac.json View 1 chunk +143 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan.json View 1 chunk +144 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac__dbg_.json View 1 chunk +94 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin.json View 1 chunk +168 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64.json View 1 chunk +168 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_dbg_.json View 1 chunk +165 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_dll_.json View 1 chunk +165 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin_dbg_.json View 1 chunk +165 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin_dll_.json View 1 chunk +165 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTiOS.json View 1 chunk +18 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang.json View 1 chunk +108 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64.json View 1 chunk +108 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_dbg_.json View 1 chunk +69 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_dll_.json View 1 chunk +105 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangLLD.json View 1 chunk +111 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangLLD64.json View 1 chunk +111 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_dbg_.json View 1 chunk +105 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_shared_.json View 1 chunk +105 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClngLLD64dbg.json View 1 chunk +111 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClngLLDdbg.json View 1 chunk +111 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Mac_OpenSSL.json View 1 chunk +40 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Arm64_Builder__dbg_.json View 1 chunk +21 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_GN.json View 1 chunk +21 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_GN__dbg_.json View 1 chunk +21 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_x86_Builder__dbg_.json View 1 chunk +41 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Builder.json View 1 chunk +136 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_arm64_Builder.json View 1 chunk +58 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_android_oilpan_builder.json View 1 chunk +56 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder__dbg_.json View 1 chunk +41 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Chromium_ASAN___debug.json View 1 chunk +120 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Chromium_ASAN__symbolized_.json View 1 chunk +120 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Linux_ASAN_Builder.json View 1 chunk +71 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Linux_Debug_Builder.json View 1 chunk +53 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Linux_Snapshot_Builder.json View 1 chunk +35 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Nico
Created Revert of chromium_tests: raise infra failure when no compile targets are specified
5 years, 2 months ago (2015-09-28 18:13:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377453003/1
5 years, 2 months ago (2015-09-28 18:15:10 UTC) #2
commit-bot: I haz the power
Failed to apply patch for scripts/slave/recipe_modules/chromium_tests/api.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 2 months ago (2015-09-28 18:15:39 UTC) #4
Nico
manually landed revert in https://codereview.chromium.org/1372133003
5 years, 2 months ago (2015-09-28 18:56:28 UTC) #5
Sergiy Byelozyorov
5 years, 2 months ago (2015-09-29 07:30:18 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698