Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1377323002: Subzero: Change -asm-verbose output to print more useful info. (Closed)

Created:
5 years, 2 months ago by Jim Stichnoth
Modified:
5 years, 2 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Change -asm-verbose output to print more useful info. Frame offsets for variables are emitted using a symbolic name based on the variable's name. This makes it a bit easier to digest the asm code. For example, if variable Foo gets an esp offset 24, asm like this: ... 24(%esp) ... will instead be emitted like this: lv$Foo = 24 ... ... lv$Foo(%esp) ... Predecessor labels are printed for each basic block. Loop nest depth is printed for each basic block. (Would be nice if we had loop header info as well.) BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=238b4c160169aea53c5ab87f40fd1d454f41e590

Patch Set 1 #

Patch Set 2 : Also add predecessors and loop depth #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -5 lines) Patch
M src/IceCfg.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M src/IceCfgNode.cpp View 1 2 chunks +15 lines, -1 line 0 comments Download
M src/IceOperand.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/IceTargetLoweringX86BaseImpl.h View 1 chunk +24 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
5 years, 2 months ago (2015-10-01 06:52:00 UTC) #2
John
lgtm
5 years, 2 months ago (2015-10-01 14:26:59 UTC) #3
Jim Stichnoth
5 years, 2 months ago (2015-10-01 14:46:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
238b4c160169aea53c5ab87f40fd1d454f41e590 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698