Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1377053003: remove sse2 functions that also have ssse3 (Closed)

Created:
5 years, 2 months ago by fbarchard1
Modified:
5 years, 2 months ago
Reviewers:
harryjin
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Remove sse2 functions that also have ssse3 ARGBBlendRow_SSE2, ARGBAttenuateRow_SSE2, and MirrorRow_SSE2 Since vast majority of CPUs have SSSE3 now, removing the SSE2 improves the performance of CPU dispatching. R=harryjin@google.com BUG=none Committed: https://chromium.googlesource.com/libyuv/libyuv/+/2cc1a2b233488297d2590f744fdee8ff604f5c11

Patch Set 1 #

Patch Set 2 : lint warning fixes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -413 lines) Patch
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/row.h View 6 chunks +1 line, -17 lines 1 comment Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download
M source/convert_argb.cc View 1 4 chunks +4 lines, -18 lines 0 comments Download
M source/planar_functions.cc View 3 chunks +0 lines, -21 lines 0 comments Download
M source/rotate.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M source/row_any.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M source/row_gcc.cc View 1 14 chunks +8 lines, -179 lines 0 comments Download
M source/row_win.cc View 3 chunks +1 line, -162 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fbarchard1
5 years, 2 months ago (2015-09-30 01:35:16 UTC) #1
harryjin
https://codereview.chromium.org/1377053003/diff/20001/include/libyuv/row.h File include/libyuv/row.h (left): https://codereview.chromium.org/1377053003/diff/20001/include/libyuv/row.h#oldcode124 include/libyuv/row.h:124: #define HAS_MIRRORROW_SSE2 So for the very few SSE2 only ...
5 years, 2 months ago (2015-09-30 02:42:08 UTC) #2
harryjin
lgtm
5 years, 2 months ago (2015-09-30 17:42:59 UTC) #3
fbarchard
Tested on Prescott emulator.. passes. Performance as measured on Haswell: LIBYUV_FLAGS=-1 LIBYUV_DISABLE_ASM=0 LIBYUV_DISABLE_SSSE3=1 LIBYUV_DISABLE_AVX2=1 LIBYUV_WIDTH=1280 ...
5 years, 2 months ago (2015-09-30 21:23:43 UTC) #4
fbarchard1
5 years, 2 months ago (2015-09-30 21:24:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2cc1a2b233488297d2590f744fdee8ff604f5c11 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698