Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1376933005: Reflect email address changes in the Avatar Menu. (Closed)

Created:
5 years, 2 months ago by anthonyvd
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reflect email address changes in the Avatar Menu. This change fixes a bug where Chromium wouldn't properly refresh the account info associated with an account if the refresh period expired while the browser was not running. BUG=525207 TEST= 1. Sign in to Chrome 2. Exit the browser completely 3. Set clock forward one day 4. From another browser, change the email address associated with the account used to sign-in in 1. 5. Open Chrome 6. Left-click on the Avatar Button, the email displayed should be the new one (it might take a few seconds to refresh).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -2 lines) Patch
M components/signin/core/browser/account_fetcher_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/signin/core/browser/account_fetcher_service.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M components/signin/core/browser/account_tracker_service_unittest.cc View 3 chunks +76 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
anthonyvd
Hi Roger, can you please take a look at this change and maybe manually test ...
5 years, 2 months ago (2015-10-02 17:05:23 UTC) #2
Roger Tawa OOO till Jul 10th
On 2015/10/02 17:05:23, anthonyvd wrote: > Hi Roger, can you please take a look at ...
5 years ago (2015-12-02 19:21:04 UTC) #3
anthonyvd
5 years ago (2015-12-02 20:56:11 UTC) #4
On 2015/12/02 19:21:04, Roger Tawa wrote:
> On 2015/10/02 17:05:23, anthonyvd wrote:
> > Hi Roger, can you please take a look at this change and maybe manually test
it
> > with your Google Apps for Work account?
> > 
> > Thanks a lot!
> 
> Hi Anthony, I think this CL can be closed.  Yes/no?

Absolutely!

Powered by Google App Engine
This is Rietveld 408576698