Issue 137693003: Remove ArrayPush from the custom call generators, and instead call directly to the handler in crank…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137693003: Remove ArrayPush from the custom call generators, and instead call directly to the handler in crank… (Closed)

Created:
6 years, 11 months ago by Toon Verwaest

Modified:
6 years, 11 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove ArrayPush from the custom call generators, and instead call directly to the handler in crankshaft. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18790

Patch Set 2 : Set up the platform-specific descriptor on ARM #

Total comments: 1

Patch Set 3 : Addressed comments (+ rebase..) #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -75 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2	1 chunk	+35 lines, -0 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/isolate.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/stub-cache.h	View	1 2	2 chunks	+0 lines, -16 lines	0 comments	Download
M	src/stub-cache.cc	View	1 2	3 chunks	+0 lines, -57 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
M	test/mjsunit/object-seal.js	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mvstanton

With the comment addressed, then LGTM. https://codereview.chromium.org/137693003/diff/150001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/137693003/diff/150001/src/hydrogen.cc#newcode7692 src/hydrogen.cc:7692: Vector<HValue*>(op_vals, descriptor->environment_length())); ASSERT ...

6 years, 11 months ago (2014-01-23 09:17:03 UTC) #2

Toon Verwaest

6 years, 11 months ago (2014-01-23 16:20:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r18790 (presubmit successful).