test/mjsunit/object-seal.js - Issue 137693003: Remove ArrayPush from the custom call generators, and instead call directly to the handler in crank…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/mjsunit/object-seal.js

Issue 137693003: Remove ArrayPush from the custom call generators, and instead call directly to the handler in crank… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments (+ rebase..) Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/mjsunit/object-seal.js

diff --git a/test/mjsunit/object-seal.js b/test/mjsunit/object-seal.js

index f31f0b7dd2649513ce1a153bb358e05c95eb6091..3afddb9d60ccbcdf273e349618a4e353724a4114 100644

--- a/test/mjsunit/object-seal.js

+++ b/test/mjsunit/object-seal.js

@@ -251,8 +251,7 @@ assertOptimized(shift_call);

Object.seal(obj);

assertThrows(function() { push_call(obj); }, TypeError);

assertThrows(function() { shift_call(obj); }, TypeError);

-assertOptimized(push_call);

-// shift() doesn't have a custom call generator, so deopt will occur.

+assertUnoptimized(push_call);

assertUnoptimized(shift_call);

assertDoesNotThrow(function() { push_call(objControl); });

assertDoesNotThrow(function() { shift_call(objControl); });

« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | no next file » | no next file with comments »