Avoid eager enqueueing from resolution

Avoid eager enqueueing from resolution

BUG=
R=sigurdm@google.com

Committed: https://github.com/dart-lang/sdk/commit/dda38dfe47766b95abdbabe02b38c11010a694c4

Reverted: https://github.com/dart-lang/sdk/commit/a0ca16a77361baa6e51a789471236e4e87167e18

Committed: https://github.com/dart-lang/sdk/commit/5a68d6fa0ef981d872d608ffc52ed0decb8dddf6

[Johnni Winther, 2015-10-05 14:01:22]

johnniwinther@google.com changed reviewers:
+ sigurdm@google.com

[Johnni Winther, 2015-10-05 14:01:23]

Main changes in common/resolution.dart, js_backend/backend.dart and
resolution/registry.dart

[sigurdm, 2015-10-06 09:17:14]

LGTM

https://codereview.chromium.org/1376863004/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/common/resolution.dart (right):

https://codereview.chromium.org/1376863004/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/resolution.dart:164: enum Feature {
Should mirror usage be part of this?

https://codereview.chromium.org/1376863004/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/resolution.dart:171: /// An method with an `async`
body modifier.
An -> a

https://codereview.chromium.org/1376863004/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/resolution.dart:175: /// An method with an `async*`
body modifier.
An -> a

https://codereview.chromium.org/1376863004/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/resolution.dart:198: /// An synchronous for in
statement, like `for (var e in i) {}`.
An -> a

https://codereview.chromium.org/1376863004/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/resolution.dart:328: void registerAssert(bool
hasMessage) => _unsupported('registerAssert');
Not sure why this is unsupported?

https://codereview.chromium.org/1376863004/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/registry.dart (right):

https://codereview.chromium.org/1376863004/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/registry.dart:249: _isChecks = new
Setlet<DartType>();
Is it worth it not just initializing these in the field declaration?

https://codereview.chromium.org/1376863004/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/registry.dart:590: void
registerClosure(LocalFunctionElement element) {
?

[Johnni Winther, 2015-10-06 10:48:43]

https://codereview.chromium.org/1376863004/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/common/resolution.dart (right):

https://codereview.chromium.org/1376863004/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/resolution.dart:164: enum Feature {
On 2015/10/06 09:17:13, sigurdm wrote:
> Should mirror usage be part of this?

Added TODO.

https://codereview.chromium.org/1376863004/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/resolution.dart:171: /// An method with an `async`
body modifier.
On 2015/10/06 09:17:13, sigurdm wrote:
> An -> a

Done.

https://codereview.chromium.org/1376863004/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/resolution.dart:175: /// An method with an `async*`
body modifier.
On 2015/10/06 09:17:13, sigurdm wrote:
> An -> a

Done.

https://codereview.chromium.org/1376863004/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/resolution.dart:198: /// An synchronous for in
statement, like `for (var e in i) {}`.
On 2015/10/06 09:17:14, sigurdm wrote:
> An -> a

Done.

https://codereview.chromium.org/1376863004/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/resolution.dart:328: void registerAssert(bool
hasMessage) => _unsupported('registerAssert');
On 2015/10/06 09:17:14, sigurdm wrote:
> Not sure why this is unsupported?

Not currently needed. Added to TODO to remove it.

https://codereview.chromium.org/1376863004/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/registry.dart (right):

https://codereview.chromium.org/1376863004/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/registry.dart:249: _isChecks = new
Setlet<DartType>();
On 2015/10/06 09:17:14, sigurdm wrote:
> Is it worth it not just initializing these in the field declaration?

Maybe. Have to investigate further. Adding a TODO.

https://codereview.chromium.org/1376863004/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/registry.dart:590: void
registerClosure(LocalFunctionElement element) {
On 2015/10/06 09:17:14, sigurdm wrote:
> ?

Code is moved to .transformImpact

[Johnni Winther, 2015-10-06 11:53:25]

Committed patchset #3 (id:40001) manually as
dda38dfe47766b95abdbabe02b38c11010a694c4 (presubmit successful).

[Johnni Winther, 2015-10-07 07:47:21]

Patchset #4 (id:60001) has been deleted

[Johnni Winther, 2015-10-07 07:53:36]

PTAL @ the last patch

[sigurdm, 2015-10-07 08:16:13]

LGTM

[Johnni Winther, 2015-10-07 08:41:32]

Committed patchset #5 (id:100001) manually as
5a68d6fa0ef981d872d608ffc52ed0decb8dddf6 (presubmit successful).