pkg/compiler/lib/src/common/codegen.dart - Issue 1376863004: Avoid eager enqueueing from resolution

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/common/codegen.dart

Issue 1376863004: Avoid eager enqueueing from resolution (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Fix deferred+mirrors bug. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/common/codegen.dart

diff --git a/pkg/compiler/lib/src/common/codegen.dart b/pkg/compiler/lib/src/common/codegen.dart

index e220aabde260f63c44210af35cbfe1f25eaf553a..e5554c9642a240c97dbab70ed9df1897a77c1395 100644

--- a/pkg/compiler/lib/src/common/codegen.dart

+++ b/pkg/compiler/lib/src/common/codegen.dart

@@ -191,7 +191,7 @@ class CodegenWorkItem extends WorkItem {

// generation could spuriously be adding dependencies on things we know we

// don't need.

assert(invariant(element,

- compiler.enqueuer.resolution.hasBeenResolved(element),

+ compiler.enqueuer.resolution.hasBeenProcessed(element),

message: "$element has not been resolved."));

assert(invariant(element, element.resolvedAst.elements != null,

message: 'Resolution tree is null for $element in codegen work item'));