Remove the TRACE_EVENT_*_ETW macros.

Remove the TRACE_EVENT_*_ETW macros.

All tracing macros can now export events to ETW (see
TraceEventETWExport). Therefore, there is no reason to keep the
TRACE_EVENT_*_ETW macros. This patch removes all code related to these.

The base::win::EtwTraceProvider class is not removed as it's still
used for logging.

BUG=489720
Committed: https://crrev.com/c435ad212c532a60e9e6fcd548ea4b09bc5363fd
Cr-Commit-Position: refs/heads/master@{#353272}

[fdoray, 2015-10-06 19:51:23]

fdoray@chromium.org changed reviewers:
+ beaudoin@chromium.org, brettw@chromium.org, grt@chromium.org,
nduca@chromium.org

[fdoray, 2015-10-06 19:51:24]

Could you review this CL? Thanks.

[beaudoin, 2015-10-06 20:59:34]

beaudoin@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2015-10-06 21:10:45]

You probably need to migrate the uses of the macro before removing the macro.

content/app/android/library_loader_hooks.cc: 
TRACE_EVENT_BEGIN_ETW("BrowserMain", 0, "");
content/browser/browser_main.cc:  TRACE_EVENT_BEGIN_ETW("BrowserMain", 0, "");
content/browser/browser_main_loop.cc: 
TRACE_EVENT_BEGIN_ETW("BrowserMain:MESSAGE_LOOP", 0, "");
content/common/gpu/media/dxva_video_decode_accelerator.cc:   
TRACE_EVENT_BEGIN_ETW("DXVAVideoDecodeAccelerator.Decoding", this, "");
content/common/sandbox_win.cc:  TRACE_EVENT_BEGIN_ETW("StartProcessWithAccess",
0, type_str);
content/common/sandbox_win.cc: 
TRACE_EVENT_BEGIN_ETW("StartProcessWithAccess::LAUNCHPROCESS", 0, 0);
content/renderer/render_thread_impl.cc: 
TRACE_EVENT_BEGIN_ETW("RenderThreadImpl::Init", 0, "");
content/renderer/renderer_main.cc:  TRACE_EVENT_BEGIN_ETW("RendererMain", 0,
"");
content/renderer/renderer_main.cc:     
TRACE_EVENT_BEGIN_ETW("RendererMain.START_MSG_LOOP", 0, 0);

content/browser/browser_main.cc:  TRACE_EVENT_END_ETW("BrowserMain", 0, 0);
content/browser/browser_main_loop.cc: 
TRACE_EVENT_END_ETW("BrowserMain:MESSAGE_LOOP", 0, "");
content/common/gpu/media/dxva_video_decode_accelerator.cc: 
TRACE_EVENT_END_ETW("DXVAVideoDecodeAccelerator.Decoding", this, "");
content/common/sandbox_win.cc: 
TRACE_EVENT_END_ETW("StartProcessWithAccess::LAUNCHPROCESS", 0, 0);
content/common/sandbox_win.cc:  TRACE_EVENT_END_ETW("StartProcessWithAccess", 0,
type_str);
content/renderer/render_thread_impl.cc: 
TRACE_EVENT_END_ETW("RenderThreadImpl::Init", 0, "");
content/renderer/renderer_main.cc:     
TRACE_EVENT_END_ETW("RendererMain.START_MSG_LOOP", 0, 0);
content/renderer/renderer_main.cc:  TRACE_EVENT_END_ETW("RendererMain", 0, "");

[dsinclair, 2015-10-06 21:11:17]

On 2015/10/06 21:10:45, dsinclair wrote:
> You probably need to migrate the uses of the macro before removing the macro.
> 
> content/app/android/library_loader_hooks.cc: 
> TRACE_EVENT_BEGIN_ETW("BrowserMain", 0, "");
> content/browser/browser_main.cc:  TRACE_EVENT_BEGIN_ETW("BrowserMain", 0, "");
> content/browser/browser_main_loop.cc: 
> TRACE_EVENT_BEGIN_ETW("BrowserMain:MESSAGE_LOOP", 0, "");
> content/common/gpu/media/dxva_video_decode_accelerator.cc:   
> TRACE_EVENT_BEGIN_ETW("DXVAVideoDecodeAccelerator.Decoding", this, "");
> content/common/sandbox_win.cc: 
TRACE_EVENT_BEGIN_ETW("StartProcessWithAccess",
> 0, type_str);
> content/common/sandbox_win.cc: 
> TRACE_EVENT_BEGIN_ETW("StartProcessWithAccess::LAUNCHPROCESS", 0, 0);
> content/renderer/render_thread_impl.cc: 
> TRACE_EVENT_BEGIN_ETW("RenderThreadImpl::Init", 0, "");
> content/renderer/renderer_main.cc:  TRACE_EVENT_BEGIN_ETW("RendererMain", 0,
> "");
> content/renderer/renderer_main.cc:     
> TRACE_EVENT_BEGIN_ETW("RendererMain.START_MSG_LOOP", 0, 0);
> 
> content/browser/browser_main.cc:  TRACE_EVENT_END_ETW("BrowserMain", 0, 0);
> content/browser/browser_main_loop.cc: 
> TRACE_EVENT_END_ETW("BrowserMain:MESSAGE_LOOP", 0, "");
> content/common/gpu/media/dxva_video_decode_accelerator.cc: 
> TRACE_EVENT_END_ETW("DXVAVideoDecodeAccelerator.Decoding", this, "");
> content/common/sandbox_win.cc: 
> TRACE_EVENT_END_ETW("StartProcessWithAccess::LAUNCHPROCESS", 0, 0);
> content/common/sandbox_win.cc:  TRACE_EVENT_END_ETW("StartProcessWithAccess",
0,
> type_str);
> content/renderer/render_thread_impl.cc: 
> TRACE_EVENT_END_ETW("RenderThreadImpl::Init", 0, "");
> content/renderer/renderer_main.cc:     
> TRACE_EVENT_END_ETW("RendererMain.START_MSG_LOOP", 0, 0);
> content/renderer/renderer_main.cc:  TRACE_EVENT_END_ETW("RendererMain", 0,
"");

Ah, nm, missed the link above.

[grt (UTC plus 2), 2015-10-08 11:24:03]

chrome/test/logging/* lgtm

[fdoray, 2015-10-08 17:00:36]

fdoray@chromium.org changed reviewers:
- brettw@chromium.org

[fdoray, 2015-10-08 17:01:10]

The patch that removes all uses of the TRACE_EVENT_*_ETW macros landed.

dsinclair@: Can you review base/trace_event/*?

[fdoray, 2015-10-08 17:02:20]

The patch that removes all uses of the TRACE_EVENT_*_ETW macros landed
(https://codereview.chromium.org/1386193002/).

dsinclair@: Can you review base/trace_event/*?

[dsinclair, 2015-10-08 17:07:50]

base/trace_event lgtm

[fdoray, 2015-10-08 17:33:55]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2015-10-08 17:33:55]

The patchset sent to the CQ was uploaded after l-g-t-m from grt@chromium.org
Link to the patchset: https://codereview.chromium.org/1376793004/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2015-10-08 17:37:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1376793004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1376793004/20001

[commit-bot: I haz the power, 2015-10-08 17:57:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-08 17:57:53]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)

[beaudoin, 2015-10-08 20:19:41]

The CQ bit was checked by beaudoin@chromium.org

[commit-bot: I haz the power, 2015-10-08 20:21:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1376793004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1376793004/20001

[commit-bot: I haz the power, 2015-10-08 20:44:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-08 20:44:08]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[fdoray, 2015-10-08 21:07:15]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2015-10-08 21:08:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1376793004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1376793004/20001

[commit-bot: I haz the power, 2015-10-08 21:28:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-08 21:28:04]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)

[fdoray, 2015-10-09 03:36:25]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2015-10-09 03:36:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1376793004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1376793004/20001

[commit-bot: I haz the power, 2015-10-09 05:37:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-09 05:37:09]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[fdoray, 2015-10-09 11:20:12]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2015-10-09 11:20:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1376793004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1376793004/20001

[commit-bot: I haz the power, 2015-10-09 12:30:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-09 12:31:15]

Patchset 2 (id:??) landed as
https://crrev.com/c435ad212c532a60e9e6fcd548ea4b09bc5363fd
Cr-Commit-Position: refs/heads/master@{#353272}