Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Unified Diff: chrome/test/logging/win/log_file_printer.cc

Issue 1376793004: Remove the TRACE_EVENT_*_ETW macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/logging/win/file_logger.cc ('k') | chrome/test/logging/win/log_file_reader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/logging/win/log_file_printer.cc
diff --git a/chrome/test/logging/win/log_file_printer.cc b/chrome/test/logging/win/log_file_printer.cc
index 943712aeddceb80f0c7e76467b45910e68f95f09..a03d65b9648f3060606c346f7bdc353e3ba8b2ad 100644
--- a/chrome/test/logging/win/log_file_printer.cc
+++ b/chrome/test/logging/win/log_file_printer.cc
@@ -65,25 +65,6 @@ void WriteLocationToStream(const base::StringPiece& file,
*out << filename << '(' << line << ')';
}
-// Returns a pretty string for the trace event types that appear in ETW logs.
-const char* GetTraceTypeString(char event_type) {
- switch (event_type) {
- case TRACE_EVENT_PHASE_BEGIN:
- return "BEGIN";
- break;
- case TRACE_EVENT_PHASE_END:
- return "END";
- break;
- case TRACE_EVENT_PHASE_INSTANT:
- return "INSTANT";
- break;
- default:
- NOTREACHED();
- return "";
- break;
- }
-}
-
class EventPrinter : public logging_win::LogFileDelegate {
public:
explicit EventPrinter(std::ostream* out);
@@ -108,14 +89,6 @@ class EventPrinter : public logging_win::LogFileDelegate {
const base::StringPiece& file,
const base::StringPiece& message) override;
- void OnTraceEvent(const EVENT_TRACE* event,
- const base::StringPiece& name,
- char type,
- intptr_t id,
- const base::StringPiece& extra,
- DWORD stack_depth,
- const intptr_t* backtrace) override;
-
private:
void PrintTimeStamp(LARGE_INTEGER time_stamp);
void PrintEventContext(const EVENT_TRACE* event,
@@ -225,18 +198,6 @@ void EventPrinter::OnLogMessageFull(const EVENT_TRACE* event,
*out_ << message << std::endl;
}
-void EventPrinter::OnTraceEvent(const EVENT_TRACE* event,
- const base::StringPiece& name,
- char type,
- intptr_t id,
- const base::StringPiece& extra,
- DWORD stack_depth,
- const intptr_t* backtrace) {
- PrintEventContext(event, GetTraceTypeString(type), base::StringPiece());
- *out_ << name << " (id=0x" << std::hex << id << std::dec << ") " << extra
- << std::endl;
-}
-
} // namespace
void logging_win::PrintLogFile(const base::FilePath& log_file,
« no previous file with comments | « chrome/test/logging/win/file_logger.cc ('k') | chrome/test/logging/win/log_file_reader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698