Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1376793003: Fix the flaky test by ensuring the image used by <input type=image> is loaded. (Closed)

Created:
5 years, 2 months ago by hayato
Modified:
5 years, 2 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the flaky test by ensuring the image used by <input type=image> is loaded. It looks that r186800 wrongly rebased fast/events/domactivate-sets-underlying-click-event-as-handled-expected.txt, hiding the regression. http://src.chromium.org/viewvc/blink?view=revision&revision=186800 However, the test itself has flakiness so it occasionally outputs the originally expected result correctly. That's the reason of the flakiness. This CL fixed the flakiness by ensuring the image is loaded before testing. Also reverted the wrong rebase of expected.txt in r186800. It looks there is no reliable way to know when UA displays the (default) image if <input type=image> is used without src attribute. The spec says "The src attribute must be present". https://html.spec.whatwg.org/multipage/forms.html#image-button-state-(type=image) BUG=520173 Committed: https://crrev.com/e68442e7003b776748b6d749a5cc7345d2dbed4e Cr-Commit-Position: refs/heads/master@{#351532}

Patch Set 1 #

Patch Set 2 : Fix TestExpectation #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -34 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/domactivate-sets-underlying-click-event-as-handled.html View 2 chunks +33 lines, -31 lines 1 comment Download
M third_party/WebKit/LayoutTests/fast/events/domactivate-sets-underlying-click-event-as-handled-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
hayato
PTAL
5 years, 2 months ago (2015-09-30 08:03:51 UTC) #2
hayato
https://codereview.chromium.org/1376793003/diff/20001/third_party/WebKit/LayoutTests/fast/events/domactivate-sets-underlying-click-event-as-handled.html File third_party/WebKit/LayoutTests/fast/events/domactivate-sets-underlying-click-event-as-handled.html (right): https://codereview.chromium.org/1376793003/diff/20001/third_party/WebKit/LayoutTests/fast/events/domactivate-sets-underlying-click-event-as-handled.html#newcode33 third_party/WebKit/LayoutTests/fast/events/domactivate-sets-underlying-click-event-as-handled.html:33: document.querySelector("input[type=image]").addEventListener("load", function() { The diff is difficult to read. ...
5 years, 2 months ago (2015-09-30 08:12:09 UTC) #3
tkent
lgtm
5 years, 2 months ago (2015-09-30 08:12:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376793003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376793003/20001
5 years, 2 months ago (2015-09-30 08:14:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/109787)
5 years, 2 months ago (2015-09-30 08:26:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376793003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376793003/20001
5 years, 2 months ago (2015-09-30 11:14:54 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-30 11:21:21 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 11:22:08 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e68442e7003b776748b6d749a5cc7345d2dbed4e
Cr-Commit-Position: refs/heads/master@{#351532}

Powered by Google App Engine
This is Rietveld 408576698