Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: third_party/WebKit/LayoutTests/fast/events/domactivate-sets-underlying-click-event-as-handled.html

Issue 1376793003: Fix the flaky test by ensuring the image used by <input type=image> is loaded. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix TestExpectation Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/events/domactivate-sets-underlying-click-event-as-handled.html
diff --git a/third_party/WebKit/LayoutTests/fast/events/domactivate-sets-underlying-click-event-as-handled.html b/third_party/WebKit/LayoutTests/fast/events/domactivate-sets-underlying-click-event-as-handled.html
index 649c9af5820f5291b7b4a53adede95defcdfb8cf..d5106257a3031fe579165402a34e31c139e20e02 100644
--- a/third_party/WebKit/LayoutTests/fast/events/domactivate-sets-underlying-click-event-as-handled.html
+++ b/third_party/WebKit/LayoutTests/fast/events/domactivate-sets-underlying-click-event-as-handled.html
@@ -5,7 +5,7 @@ element. The anchor shouldn't be activated (i.e. you shouldn't see any "anchor a
<form action="javascript:formSubmitted()">
<input type=text>
<input type=submit>
- <input type=image>
+ <input src="resources/abe.png" type=image>
<button>button</button>
<input type=reset>
<button type=reset>button reset</button>
@@ -30,43 +30,45 @@ function anchorActivated() { log("anchor activated\n"); }
document.forms[0].children[0].value = "blah";
-for (var i=0; i < document.forms[0].children.length; i++) {
- var element = document.forms[0].children[i];
+document.querySelector("input[type=image]").addEventListener("load", function() {
hayato 2015/09/30 08:12:09 The diff is difficult to read. It just wraps the e
+ for (var i=0; i < document.forms[0].children.length; i++) {
+ var element = document.forms[0].children[i];
- element.addEventListener("click", function () {
- log("Activated " + this + " type=" + this.type);
- }, false);
+ element.addEventListener("click", function () {
+ log("Activated " + this + " type=" + this.type);
+ }, false);
- if (!window.eventSender)
- continue;
+ if (!window.eventSender)
+ continue;
+
+ if (element.type == "text") {
+ log("Focusing " + element + " type=" + element.type + " and pressing enter");
+ element.focus();
+ eventSender.keyDown("\n");
+ continue;
+ }
+
+ eventSender.mouseMoveTo(element.offsetLeft + element.clientWidth / 2, element.offsetTop + element.clientHeight / 2);
+ eventSender.mouseDown();
+ eventSender.mouseUp();
+
+ if (element.type == "radio" || element.type == "checkbox")
+ continue;
- if (element.type == "text") {
log("Focusing " + element + " type=" + element.type + " and pressing enter");
element.focus();
eventSender.keyDown("\n");
- continue;
}
- eventSender.mouseMoveTo(element.offsetLeft + element.clientWidth / 2, element.offsetTop + element.clientHeight / 2);
- eventSender.mouseDown();
- eventSender.mouseUp();
-
- if (element.type == "radio" || element.type == "checkbox")
- continue;
-
- log("Focusing " + element + " type=" + element.type + " and pressing enter");
- element.focus();
- eventSender.keyDown("\n");
-}
-
-if (window.eventSender) {
- var details = document.querySelector("details");
- eventSender.mouseMoveTo(details.offsetLeft + details.clientWidth / 2, details.offsetTop + details.clientHeight / 2);
- eventSender.mouseDown();
- eventSender.mouseUp();
- log("\nThe details element was " + (details.open ? "" : "not ") + "opened");
-}
+ if (window.eventSender) {
+ var details = document.querySelector("details");
+ eventSender.mouseMoveTo(details.offsetLeft + details.clientWidth / 2, details.offsetTop + details.clientHeight / 2);
+ eventSender.mouseDown();
+ eventSender.mouseUp();
+ log("\nThe details element was " + (details.open ? "" : "not ") + "opened");
+ }
-if (window.testRunner)
- document.querySelector("a").style.display = "none";
+ if (window.testRunner)
+ document.querySelector("a").style.display = "none";
+});
</script>

Powered by Google App Engine
This is Rietveld 408576698