chrome/browser/media/android/router/media_router_android.cc - Issue 1376703002: Presentation API: reject screen availability observing on Android low ram devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/android/router/media_router_android.cc

Issue 1376703002: Presentation API: reject screen availability observing on Android low ram devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments and compile fix Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java ('K') | « chrome/browser/media/android/router/media_router_android.h ('k') | chrome/browser/media/router/media_router.h » ('j') | chrome/browser/media/router/media_sinks_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/android/router/media_router_android.cc

diff --git a/chrome/browser/media/android/router/media_router_android.cc b/chrome/browser/media/android/router/media_router_android.cc

index a89f961c716c0d30e5d303b0bd902175d134807a..10d0122ee661a883a758038b5fc168bee3bd40c2 100644

--- a/chrome/browser/media/android/router/media_router_android.cc

+++ b/chrome/browser/media/android/router/media_router_android.cc

@@ -188,7 +188,7 @@ void MediaRouterAndroid::OnPresentationSessionDetached(

NOTIMPLEMENTED();

}

-void MediaRouterAndroid::RegisterMediaSinksObserver(

+bool MediaRouterAndroid::RegisterMediaSinksObserver(

MediaSinksObserver* observer) {

const std::string& source_id = observer->source().id();

base::ObserverList<MediaSinksObserver>* observer_list =

@@ -204,7 +204,7 @@ void MediaRouterAndroid::RegisterMediaSinksObserver(

JNIEnv* env = base::android::AttachCurrentThread();

ScopedJavaLocalRef<jstring> jsource_id =

base::android::ConvertUTF8ToJavaString(env, source_id);

- Java_ChromeMediaRouter_startObservingMediaSinks(

+ return Java_ChromeMediaRouter_startObservingMediaSinks(

env, java_media_router_.obj(), jsource_id.obj());

}