chrome/browser/media/router/media_sinks_observer.cc - Issue 1376703002: Presentation API: reject screen availability observing on Android low ram devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/media_sinks_observer.cc

Issue 1376703002: Presentation API: reject screen availability observing on Android low ram devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments and compile fix Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java ('K') | « chrome/browser/media/router/media_sinks_observer.h ('k') | chrome/browser/media/router/mock_media_router.h » ('j') | chrome/browser/media/router/presentation_service_delegate_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/media_sinks_observer.cc

diff --git a/chrome/browser/media/router/media_sinks_observer.cc b/chrome/browser/media/router/media_sinks_observer.cc

index 7a08d54bb195ec92703e96095c6f5f8b867fb641..ea57e38e085d36e15207ba1f3fdb5d72b8117c7b 100644

--- a/chrome/browser/media/router/media_sinks_observer.cc

+++ b/chrome/browser/media/router/media_sinks_observer.cc

@@ -13,7 +13,7 @@ MediaSinksObserver::MediaSinksObserver(MediaRouter* router,

const MediaSource& source)

: source_(source), router_(router) {

DCHECK(router_);

- router_->RegisterMediaSinksObserver(this);

+ is_active_ = router_->RegisterMediaSinksObserver(this);

whywhat 2015/09/29 12:29:22 Maybe we shouldn't actually do this work in the ct

mlamouri (slow - plz ping) 2015/09/29 14:44:52 As discussed, we could have a ::Create() static me

}

MediaSinksObserver::~MediaSinksObserver() {