Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4283)

Unified Diff: chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

Issue 1376703002: Presentation API: reject screen availability observing on Android low ram devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix and add tests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
diff --git a/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc b/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
index 2534510bc19eb84079fd5d15d49af42b6f6b0c5e..056f05d447019cd55472c3947255bc84691d3ffb 100644
--- a/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
+++ b/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
@@ -60,6 +60,8 @@ class PresentationServiceDelegateImplTest
};
TEST_F(PresentationServiceDelegateImplTest, AddScreenAvailabilityListener) {
+ ON_CALL(router_, RegisterMediaSinksObserver(_)).WillByDefault(Return(true));
+
std::string presentation_url1("http://url1");
std::string presentation_url2("http://url2");
MediaSource source1 = MediaSourceForPresentationUrl(presentation_url1);
@@ -94,6 +96,8 @@ TEST_F(PresentationServiceDelegateImplTest, AddScreenAvailabilityListener) {
}
TEST_F(PresentationServiceDelegateImplTest, AddSameListenerTwice) {
+ ON_CALL(router_, RegisterMediaSinksObserver(_)).WillByDefault(Return(true));
+
std::string presentation_url1("http://url1");
MediaSource source1(MediaSourceForPresentationUrl(presentation_url1));
MockScreenAvailabilityListener listener1(presentation_url1);
@@ -182,6 +186,8 @@ TEST_F(PresentationServiceDelegateImplTest, DefaultMediaSourceObserver) {
}
TEST_F(PresentationServiceDelegateImplTest, Reset) {
+ ON_CALL(router_, RegisterMediaSinksObserver(_)).WillByDefault(Return(true));
+
std::string presentation_url1("http://url1");
MediaSource source = MediaSourceForPresentationUrl(presentation_url1);
MockScreenAvailabilityListener listener1(presentation_url1);
@@ -216,4 +222,17 @@ TEST_F(PresentationServiceDelegateImplTest, DelegateObservers) {
manager.reset();
}
+TEST_F(PresentationServiceDelegateImplTest, SinksObserverCantRegister) {
+ ON_CALL(router_, RegisterMediaSinksObserver(_)).WillByDefault(Return(false));
+
+ const std::string presentation_url("http://url1");
+ MockScreenAvailabilityListener listener(presentation_url);
+ const int render_process_id = 10;
+ const int render_frame_id = 1;
+
+ EXPECT_CALL(router_, RegisterMediaSinksObserver(_)).Times(1);
+ EXPECT_FALSE(delegate_impl_->AddScreenAvailabilityListener(
+ render_process_id, render_frame_id, &listener));
+}
+
} // namespace media_router

Powered by Google App Engine
This is Rietveld 408576698