chrome/browser/media/router/presentation_service_delegate_impl.cc - Issue 1376703002: Presentation API: reject screen availability observing on Android low ram devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/presentation_service_delegate_impl.cc

Issue 1376703002: Presentation API: reject screen availability observing on Android low ram devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix and add tests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/mock_screen_availability_listener.h ('k') | chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/presentation_service_delegate_impl.cc

diff --git a/chrome/browser/media/router/presentation_service_delegate_impl.cc b/chrome/browser/media/router/presentation_service_delegate_impl.cc

index e03063d83228cd22368d63c42e78bebb6675992a..e2010440ff76b1e2ebe1828dd2dd756b2e24daf4 100644

--- a/chrome/browser/media/router/presentation_service_delegate_impl.cc

+++ b/chrome/browser/media/router/presentation_service_delegate_impl.cc

@@ -178,12 +178,19 @@ const std::vector<MediaRoute::Id> PresentationFrame::GetRouteIds() const {

bool PresentationFrame::SetScreenAvailabilityListener(

content::PresentationScreenAvailabilityListener* listener) {

- if (sinks_observer_ && sinks_observer_->listener() == listener) {

+ if (sinks_observer_ && sinks_observer_->listener() == listener)

return false;

- }

MediaSource source(GetMediaSourceFromListener(listener));

sinks_observer_.reset(

new PresentationMediaSinksObserver(router_, listener, source));

+ if (!sinks_observer_->is_active()) {

+ sinks_observer_.reset();

+ listener->OnScreenAvailabilityNotSupported();

+ return false;

+ }

return true;

}