Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2951)

Unified Diff: chrome/browser/devtools/device/adb/adb_client_socket.cc

Issue 1376473003: Notify NQE of TCP RTT values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed net tests compilation issues, Added tests Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/device/adb/adb_client_socket.cc
diff --git a/chrome/browser/devtools/device/adb/adb_client_socket.cc b/chrome/browser/devtools/device/adb/adb_client_socket.cc
index e65375bee312bb54f20fc9aa2c1c7c9ff2c665d1..07c2089d6bb05bc464c5d32d1f389f48a8422edd 100644
--- a/chrome/browser/devtools/device/adb/adb_client_socket.cc
+++ b/chrome/browser/devtools/device/adb/adb_client_socket.cc
@@ -181,7 +181,7 @@ void AdbClientSocket::Connect(const net::CompletionCallback& callback) {
net::AddressList address_list =
net::AddressList::CreateFromIPAddress(ip_number, port_);
- socket_.reset(new net::TCPClientSocket(address_list, NULL,
+ socket_.reset(new net::TCPClientSocket(address_list, NULL, NULL,
bengr 2016/02/08 18:51:14 There aren't a lot of uses of NULL in this file so
tbansal1 2016/02/08 21:33:26 This CL is already huge :(. So, I would prefer not
bengr 2016/02/08 23:42:06 Acknowledged.
net::NetLog::Source()));
bengr 2016/02/08 18:51:14 Also, /* inline comments */ would be helpful next
tbansal1 2016/02/08 21:33:26 I think inline comments are discouraged in Chromiu
bengr 2016/02/08 23:42:06 I've seen it both ways in Chromium, but I'll defer
tbansal1 2016/02/09 17:11:22 Acknowledged.
int result = socket_->Connect(callback);
if (result != net::ERR_IO_PENDING)
« no previous file with comments | « no previous file | chrome/browser/devtools/device/port_forwarding_controller.cc » ('j') | net/base/network_quality_estimator.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698