Notify NQE of TCP RTT values

chrome/browser/devtools/device/adb/adb_client_socket.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/devtools/device/adb/adb_client_socket.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 163 matching lines @@
 
 void AdbClientSocket::Connect(const net::CompletionCallback& callback) {
   net::IPAddressNumber ip_number;
   if (!net::ParseIPLiteralToNumber(host_, &ip_number)) {
     callback.Run(net::ERR_FAILED);
     return;
   }
 
   net::AddressList address_list =
       net::AddressList::CreateFromIPAddress(ip_number, port_);
-  socket_.reset(new net::TCPClientSocket(address_list, NULL,
+  socket_.reset(new net::TCPClientSocket(address_list, NULL, NULL,

[bengr, 2016/02/08 18:51:14]

There aren't a lot of uses of NULL in this file so consider replacing all of
them with nullptr. Consider this for all file where you use NULL instead of
nullptr.

[tbansal1, 2016/02/08 21:33:26]

This CL is already huge :(. So, I would prefer not to change other code.

[bengr, 2016/02/08 23:42:06]

Acknowledged.

                                          net::NetLog::Source()));

[bengr, 2016/02/08 18:51:14]

Also, /* inline comments */ would be helpful next to each nullptr parameter so
we know what they are.

[tbansal1, 2016/02/08 21:33:26]

I think inline comments are discouraged in Chromium net stack code:
https://codereview.chromium.org/1376473003/diff/1/device/bluetooth/bluetooth_...

[bengr, 2016/02/08 23:42:06]

I've seen it both ways in Chromium, but I'll defer to the comment from the net/
owner.

[tbansal1, 2016/02/09 17:11:22]

Acknowledged.

   int result = socket_->Connect(callback);
   if (result != net::ERR_IO_PENDING)
     callback.Run(result);
 }
 
 void AdbClientSocket::SendCommand(const std::string& command,
                                   bool is_void,
                                   const CommandCallback& callback) {
   scoped_refptr<net::StringIOBuffer> request_buffer =
       new net::StringIOBuffer(EncodeMessage(command));
@@ skipping 96 matching lines @@
                                     base::Unretained(this),
                                     callback,
                                     new_response,
                                     response_buffer,
                                     bytes_left));
   if (result > 0)
     OnResponseData(callback, new_response, response_buffer, bytes_left, result);
   else if (result != net::ERR_IO_PENDING)
     callback.Run(net::OK, new_response);
 }