Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1376473002: Move feConvolveMatrix error handling to FEConvolveMatrix (Closed)

Created:
5 years, 2 months ago by fs
Modified:
5 years, 2 months ago
CC:
fs, blink-reviews, Rik, chromium-reviews, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), gyuyoung2, jbroman, Justin Novosad, kouhei+svg_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move feConvolveMatrix error handling to FEConvolveMatrix This moves the checking of error-conditions from SVGFEConvolveMatrixElement::build to SkImageFilter build time (FEConvolveMatrix::createImageFilter), with the change in behavior that an feConvolveMatrix primitive that is "in error" now produces transparent black rather than fail the chain (for 'filter' - is ignored for '-webkit-filter'). This new behavior matches Gecko. The 'order' vs. size('kernelMatrix') checking is also strengthed / made more obvious by explicitly failing when overflowing the (positive) int range. (And avoids depending on signed overflow.) Also introduce a helper FilterEffect::createTransparentBlack and use in FEConvolveMatrix and FEImage, and drop a bunch of unused accessor methods on FEConvolveMatrix. BUG=533457 Committed: https://crrev.com/a5c80d87788a2aec8c82ba24345aae731e1d2c71 Cr-Commit-Position: refs/heads/master@{#351139}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
fs
5 years, 2 months ago (2015-09-28 13:55:10 UTC) #2
Stephen White
LGTM I like the createTransparentBlack() change. +1 for self-documenting code.
5 years, 2 months ago (2015-09-28 14:03:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376473002/1
5 years, 2 months ago (2015-09-28 19:50:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 20:56:44 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 20:58:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5c80d87788a2aec8c82ba24345aae731e1d2c71
Cr-Commit-Position: refs/heads/master@{#351139}

Powered by Google App Engine
This is Rietveld 408576698