DescriptionMove feConvolveMatrix error handling to FEConvolveMatrix
This moves the checking of error-conditions from
SVGFEConvolveMatrixElement::build to SkImageFilter build time
(FEConvolveMatrix::createImageFilter), with the change in behavior that
an feConvolveMatrix primitive that is "in error" now produces
transparent black rather than fail the chain (for 'filter' - is ignored
for '-webkit-filter'). This new behavior matches Gecko.
The 'order' vs. size('kernelMatrix') checking is also strengthed / made
more obvious by explicitly failing when overflowing the (positive) int
range. (And avoids depending on signed overflow.)
Also introduce a helper FilterEffect::createTransparentBlack and use in
FEConvolveMatrix and FEImage, and drop a bunch of unused accessor
methods on FEConvolveMatrix.
BUG=533457
Committed: https://crrev.com/a5c80d87788a2aec8c82ba24345aae731e1d2c71
Cr-Commit-Position: refs/heads/master@{#351139}
Patch Set 1 #Messages
Total messages: 7 (2 generated)
|