Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h

Issue 1376473002: Move feConvolveMatrix error handling to FEConvolveMatrix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h
diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h b/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h
index 07be8dab0652629f79f1f9a166526df0267f87c7..a80099a2aff29667ba745cf11d6f23962745c7bc 100644
--- a/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h
+++ b/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h
@@ -44,25 +44,10 @@ public:
static PassRefPtrWillBeRawPtr<FEConvolveMatrix> create(Filter*, const IntSize&,
float, float, const IntPoint&, EdgeModeType, bool, const Vector<float>&);
- IntSize kernelSize() const;
- void setKernelSize(const IntSize&);
-
- const Vector<float>& kernel() const;
- void setKernel(const Vector<float>&);
-
- float divisor() const;
bool setDivisor(float);
-
- float bias() const;
bool setBias(float);
-
- IntPoint targetOffset() const;
bool setTargetOffset(const IntPoint&);
-
- EdgeModeType edgeMode() const;
bool setEdgeMode(EdgeModeType);
-
- bool preserveAlpha() const;
bool setPreserveAlpha(bool);
PassRefPtr<SkImageFilter> createImageFilter(SkiaImageFilterBuilder*) override;
@@ -75,6 +60,8 @@ private:
FEConvolveMatrix(Filter*, const IntSize&, float, float,
const IntPoint&, EdgeModeType, bool, const Vector<float>&);
+ bool parametersValid() const;
+
IntSize m_kernelSize;
float m_divisor;
float m_bias;

Powered by Google App Engine
This is Rietveld 408576698