Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1376443002: Refactored interface of FeedbackVectorSpec and friends. (Closed)

Created:
5 years, 2 months ago by Igor Sheludko
Modified:
5 years, 2 months ago
Reviewers:
mvstanton, ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Refactored interface of FeedbackVectorSpec and friends. This is a second step towards merging FeedbackVectorSlot and FeedbackVectorICSlot. Committed: https://crrev.com/b2d82a22a1ded7ee3ad9b1ee7a6889187a0befde Cr-Commit-Position: refs/heads/master@{#30971}

Patch Set 1 : #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -257 lines) Patch
M src/ast.h View 15 chunks +41 lines, -127 lines 0 comments Download
M src/ast.cc View 1 8 chunks +49 lines, -65 lines 0 comments Download
M src/ast-numbering.cc View 1 chunk +2 lines, -15 lines 0 comments Download
M src/factory.h View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/type-feedback-vector.h View 3 chunks +58 lines, -15 lines 0 comments Download
M src/type-feedback-vector.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 4 chunks +23 lines, -16 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (10 generated)
Igor Sheludko
PTAL
5 years, 2 months ago (2015-09-28 10:56:39 UTC) #5
mvstanton
LGTM, very nice!
5 years, 2 months ago (2015-09-28 11:08:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376443002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376443002/100001
5 years, 2 months ago (2015-09-28 11:18:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6135)
5 years, 2 months ago (2015-09-28 11:21:17 UTC) #12
ulan
The heap related part lgtm
5 years, 2 months ago (2015-09-28 11:31:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376443002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376443002/100001
5 years, 2 months ago (2015-09-28 11:32:11 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:100001)
5 years, 2 months ago (2015-09-28 11:41:47 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 11:41:59 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b2d82a22a1ded7ee3ad9b1ee7a6889187a0befde
Cr-Commit-Position: refs/heads/master@{#30971}

Powered by Google App Engine
This is Rietveld 408576698