Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1372003002: Removing the Class/ObjectLiteral::LayoutFeedbackSlots(). (Closed)

Created:
5 years, 2 months ago by Igor Sheludko
Modified:
5 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@vect
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Removing the Class/ObjectLiteral::LayoutFeedbackSlots(). Committed: https://crrev.com/27ff0671a01ef065363a0764a9a17aaa1fcd341d Cr-Commit-Position: refs/heads/master@{#30974}

Patch Set 1 #

Patch Set 2 : Fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -95 lines) Patch
M src/ast.h View 1 4 chunks +6 lines, -37 lines 0 comments Download
M src/ast.cc View 7 chunks +10 lines, -54 lines 0 comments Download
M src/ast-numbering.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/type-feedback-vector.h View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1376443002 Patch 100001

Messages

Total messages: 7 (2 generated)
Igor Sheludko
PTAL
5 years, 2 months ago (2015-09-28 11:56:12 UTC) #2
mvstanton
excellent stuff. LGTM.
5 years, 2 months ago (2015-09-28 12:31:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372003002/20001
5 years, 2 months ago (2015-09-28 12:42:53 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 13:02:48 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 13:03:02 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/27ff0671a01ef065363a0764a9a17aaa1fcd341d
Cr-Commit-Position: refs/heads/master@{#30974}

Powered by Google App Engine
This is Rietveld 408576698