Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1376413005: Revert of [heap] Prepare code for smaller large object allocation limit than max allocatable memory. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Prepare code for smaller large object allocation limit than max allocatable memory. (patchset #10 id:180001 of https://codereview.chromium.org/1361853005/ ) Reason for revert: [Sheriff] Need to revert for reverting https://codereview.chromium.org/1358703003/ Original issue's description: > [heap] Prepare heap for smaller large object allocation limit than max allocatable memory. > > BUG=chromium:524425 > LOG=n > > Committed: https://crrev.com/c2bce747993c445daf78975392e587bff20c6677 > Cr-Commit-Position: refs/heads/master@{#31107} TBR=mlippautz@chromium.org,mstarzinger@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524425 Committed: https://crrev.com/9af0174f03e5a93c330d8dfad1aba16915d9c8ff Cr-Commit-Position: refs/heads/master@{#31129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -98 lines) Patch
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/elements.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.h View 6 chunks +9 lines, -12 lines 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/objects.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.h View 2 chunks +12 lines, -53 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 4 chunks +35 lines, -10 lines 0 comments Download
M test/cctest/test-spaces.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-weakmaps.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/test-weaksets.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [heap] Prepare code for smaller large object allocation limit than max allocatable ...
5 years, 2 months ago (2015-10-06 17:11:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376413005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376413005/1
5 years, 2 months ago (2015-10-06 17:11:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 17:11:36 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 17:11:46 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9af0174f03e5a93c330d8dfad1aba16915d9c8ff
Cr-Commit-Position: refs/heads/master@{#31129}

Powered by Google App Engine
This is Rietveld 408576698