Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1361853005: [heap] Prepare code for smaller large object allocation limit than max allocatable memory. (Closed)

Created:
5 years, 3 months ago by Hannes Payer (out of office)
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Prepare heap for smaller large object allocation limit than max allocatable memory. BUG=chromium:524425 LOG=n Committed: https://crrev.com/c2bce747993c445daf78975392e587bff20c6677 Cr-Commit-Position: refs/heads/master@{#31107}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 4

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -82 lines) Patch
M src/code-stubs-hydrogen.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/elements.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.h View 1 2 3 4 5 6 7 6 chunks +12 lines, -9 lines 0 comments Download
M src/heap/spaces-inl.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 3 4 5 6 7 3 chunks +4 lines, -4 lines 0 comments Download
M src/objects.h View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.h View 1 2 3 4 5 6 7 8 2 chunks +53 lines, -12 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 4 5 6 7 8 4 chunks +10 lines, -35 lines 0 comments Download
M test/cctest/test-spaces.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-weakmaps.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M test/cctest/test-weaksets.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
Hannes Payer (out of office)
The actual lo limit will be changed in a separate CL to make reverting easier.
5 years, 2 months ago (2015-09-30 13:39:36 UTC) #2
Michael Lippautz
lgtm, thanks for the split https://codereview.chromium.org/1361853005/diff/100001/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/1361853005/diff/100001/test/cctest/test-api.cc#newcode6550 test/cctest/test-api.cc:6550: v8::Handle<Value> big_array = CompileRun("new ...
5 years, 2 months ago (2015-09-30 14:14:24 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/1361853005/diff/100001/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/1361853005/diff/100001/test/cctest/test-api.cc#newcode6550 test/cctest/test-api.cc:6550: v8::Handle<Value> big_array = CompileRun("new Array(5000)"); On 2015/09/30 14:14:24, Michael ...
5 years, 2 months ago (2015-10-05 13:13:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361853005/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361853005/160001
5 years, 2 months ago (2015-10-05 13:13:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6358)
5 years, 2 months ago (2015-10-05 13:16:10 UTC) #9
Hannes Payer (out of office)
Michi PTAL: compilers/* and full-codegen/*
5 years, 2 months ago (2015-10-05 16:18:47 UTC) #11
Michael Starzinger
LGTM (rubber-stamp of "compiler" and "full-codegen", didn't look at the rest).
5 years, 2 months ago (2015-10-05 16:20:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361853005/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361853005/160001
5 years, 2 months ago (2015-10-05 16:21:16 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6373)
5 years, 2 months ago (2015-10-05 16:23:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361853005/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361853005/160001
5 years, 2 months ago (2015-10-05 16:36:32 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361853005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361853005/180001
5 years, 2 months ago (2015-10-05 16:37:25 UTC) #22
commit-bot: I haz the power
Committed patchset #10 (id:180001)
5 years, 2 months ago (2015-10-05 17:03:59 UTC) #23
commit-bot: I haz the power
Patchset 10 (id:??) landed as https://crrev.com/c2bce747993c445daf78975392e587bff20c6677 Cr-Commit-Position: refs/heads/master@{#31107}
5 years, 2 months ago (2015-10-05 17:04:22 UTC) #24
Michael Achenbach
5 years, 2 months ago (2015-10-06 17:11:09 UTC) #25
Message was sent while issue was closed.
A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.chromium.org/1376413005/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Need to revert for reverting
https://codereview.chromium.org/1358703003/.

Powered by Google App Engine
This is Rietveld 408576698