Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1376333002: Temporary fix for codereview cert issue. (Closed)

Created:
5 years, 2 months ago by tandrii(chromium)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Temporary fix for codereview cert issue. BUG=537763 R=stip@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296959

Patch Set 1 #

Patch Set 2 : Better UI #

Patch Set 3 : Awesome UI #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M rietveld.py View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/upload.py View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ghost stip (do not use)
lgtm
5 years, 2 months ago (2015-09-30 21:56:22 UTC) #1
tandrii_google
PTAL again It now looks like this: tandrii@andrii:/s/infra_internal/depot_tools$ git cl upload Using 50% similarity for ...
5 years, 2 months ago (2015-09-30 22:08:35 UTC) #3
ghost stip (do not use)
Good idea. lgtm
5 years, 2 months ago (2015-09-30 22:10:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376333002/2 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376333002/2
5 years, 2 months ago (2015-09-30 22:10:42 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:2) as http://src.chromium.org/viewvc/chrome?view=rev&revision=296959
5 years, 2 months ago (2015-09-30 22:12:39 UTC) #7
ghost stip (do not use)
5 years, 2 months ago (2015-10-01 01:58:25 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:2) has been created in
https://codereview.chromium.org/1374223004/ by stip@chromium.org.

The reason for reverting is: Outage is now over.

Powered by Google App Engine
This is Rietveld 408576698