Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1376233011: Partially revert r26703 and omit regular code generation for implicit accessors. (Closed)

Created:
5 years, 2 months ago by rmacnak
Modified:
5 years, 2 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Partially undo r26703 and omit regular code generation for implicit accessors. libprecompiled.so -2.4% dart2js ARM Committed: https://github.com/dart-lang/sdk/commit/723da91f0df9e3d9ffb8a5e23d31b50451851e87

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -11 lines) Patch
M runtime/vm/flow_graph_compiler.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 2 4 chunks +6 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/precompiler.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 2 months ago (2015-10-05 17:28:58 UTC) #2
srdjan
LGTMwC https://chromiumcodereview.appspot.com/1376233011/diff/20001/runtime/vm/flow_graph_compiler.cc File runtime/vm/flow_graph_compiler.cc (right): https://chromiumcodereview.appspot.com/1376233011/diff/20001/runtime/vm/flow_graph_compiler.cc#newcode1029 runtime/vm/flow_graph_compiler.cc:1029: // deopt ids. Please adjust comment even more ...
5 years, 2 months ago (2015-10-05 17:38:25 UTC) #3
rmacnak
Committed patchset #3 (id:40001) manually as 723da91f0df9e3d9ffb8a5e23d31b50451851e87 (presubmit successful).
5 years, 2 months ago (2015-10-05 23:43:11 UTC) #4
rmacnak
5 years, 2 months ago (2015-10-05 23:43:22 UTC) #5
Message was sent while issue was closed. 
https://chromiumcodereview.appspot.com/1376233011/diff/20001/runtime/vm/flow_...
File runtime/vm/flow_graph_compiler.cc (right):

https://chromiumcodereview.appspot.com/1376233011/diff/20001/runtime/vm/flow_...
runtime/vm/flow_graph_compiler.cc:1029: // deopt ids.
On 2015/10/05 17:38:25, srdjan wrote:
> Please adjust comment even more

Returns 'true' if regular code generation should be skipped.

Powered by Google App Engine
This is Rietveld 408576698