Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: runtime/vm/precompiler.cc

Issue 1376233011: Partially revert r26703 and omit regular code generation for implicit accessors. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/precompiler.cc
diff --git a/runtime/vm/precompiler.cc b/runtime/vm/precompiler.cc
index 9a750efd69a66a376a4bb74234b88dc95fd6af7b..9a77d4a28faa21a9d28e1d9a35d5dcd90cd228a5 100644
--- a/runtime/vm/precompiler.cc
+++ b/runtime/vm/precompiler.cc
@@ -748,6 +748,9 @@ void Precompiler::BindStaticCalls(const Function& function) {
ASSERT(!target_code.IsFunctionCode());
// Allocation stub or AllocateContext or AllocateArray or ...
} else {
+ // Static calls initially call the CallStaticFunction stub because
+ // their target might not be compiled yet. After tree shaking, all
+ // static call targets are compiled.
// Cf. runtime entry PatchStaticCall called from CallStaticFunction stub.
ASSERT(target.HasCode());
target_code ^= target.CurrentCode();
@@ -755,6 +758,9 @@ void Precompiler::BindStaticCalls(const Function& function) {
code, target_code);
}
}
+
+ // We won't patch static calls anymore, so drop the static call table to save
+ // space.
code.set_static_calls_target_table(Object::empty_array());
}
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698