chrome/common/metrics/metrics_service_base.h - Issue 137623002: Let MetricsService know about some Android Activities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/metrics/metrics_service_base.h

Issue 137623002: Let MetricsService know about some Android Activities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed unnecessary ConvertAndroidStabilityPrefsToHistograms() call and added missing OVERRIDE Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/metrics_service_android.cc ('K') | « chrome/chrome_browser.gypi ('k') | chrome/common/metrics/metrics_service_base.cc » ('j') | chrome/common/metrics/metrics_service_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/metrics/metrics_service_base.h

diff --git a/chrome/common/metrics/metrics_service_base.h b/chrome/common/metrics/metrics_service_base.h

index 24e73e769cc6a3bd393467a37cc2c0e87d319438..875a62d60484285cb25411fb5adf90dfb4b0f687 100644

--- a/chrome/common/metrics/metrics_service_base.h

+++ b/chrome/common/metrics/metrics_service_base.h

@@ -43,6 +43,9 @@ class MetricsServiceBase : public base::HistogramFlattener {

// Called when we close a log.

void RecordCurrentHistograms();

+ // Record complete list of stability histograms into the current log.

Alexei Svitkine (slow) 2014/01/27 19:12:54 I would expand comment to mention what "stability

Kibeom Kim (inactive) 2014/01/29 01:52:32 Done.

+ void RecordCurrentStabilityHistograms();

// Manager for the various in-flight logs.

MetricsLogManager log_manager_;