Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: chrome/common/metrics/metrics_service_base.h

Issue 137623002: Let MetricsService know about some Android Activities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed unnecessary ConvertAndroidStabilityPrefsToHistograms() call and added missing OVERRIDE Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_METRICS_METRICS_SERVICE_BASE_H_ 5 #ifndef CHROME_COMMON_METRICS_METRICS_SERVICE_BASE_H_
6 #define CHROME_COMMON_METRICS_METRICS_SERVICE_BASE_H_ 6 #define CHROME_COMMON_METRICS_METRICS_SERVICE_BASE_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/metrics/histogram_base.h" 9 #include "base/metrics/histogram_base.h"
10 #include "base/metrics/histogram_flattener.h" 10 #include "base/metrics/histogram_flattener.h"
(...skipping 25 matching lines...) Expand all
36 // The metrics server's URL. 36 // The metrics server's URL.
37 static const char kServerUrl[]; 37 static const char kServerUrl[];
38 38
39 // The MIME type for the uploaded metrics data. 39 // The MIME type for the uploaded metrics data.
40 static const char kMimeType[]; 40 static const char kMimeType[];
41 41
42 // Record complete list of histograms into the current log. 42 // Record complete list of histograms into the current log.
43 // Called when we close a log. 43 // Called when we close a log.
44 void RecordCurrentHistograms(); 44 void RecordCurrentHistograms();
45 45
46 // Record complete list of stability histograms into the current log.
Alexei Svitkine (slow) 2014/01/27 19:12:54 I would expand comment to mention what "stability
Kibeom Kim (inactive) 2014/01/29 01:52:32 Done.
47 void RecordCurrentStabilityHistograms();
48
46 // Manager for the various in-flight logs. 49 // Manager for the various in-flight logs.
47 MetricsLogManager log_manager_; 50 MetricsLogManager log_manager_;
48 51
49 private: 52 private:
50 // |histogram_snapshot_manager_| prepares histogram deltas for transmission. 53 // |histogram_snapshot_manager_| prepares histogram deltas for transmission.
51 base::HistogramSnapshotManager histogram_snapshot_manager_; 54 base::HistogramSnapshotManager histogram_snapshot_manager_;
52 55
53 DISALLOW_COPY_AND_ASSIGN(MetricsServiceBase); 56 DISALLOW_COPY_AND_ASSIGN(MetricsServiceBase);
54 }; 57 };
55 58
56 #endif // CHROME_COMMON_METRICS_METRICS_SERVICE_BASE_H_ 59 #endif // CHROME_COMMON_METRICS_METRICS_SERVICE_BASE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698