base/metrics/statistics_recorder.h - Issue 137623002: Let MetricsService know about some Android Activities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/statistics_recorder.h

Issue 137623002: Let MetricsService know about some Android Activities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments on patch set 5 + a unit test Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/metrics/histogram_snapshot_manager_unittest.cc ('k') | chrome/android/java/ActivityTypeIds.template » ('j') | chrome/browser/metrics/metrics_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/metrics/statistics_recorder.h

diff --git a/base/metrics/statistics_recorder.h b/base/metrics/statistics_recorder.h

index 5e53f274a0e8ee289b66f908bcea83b8ef6f1362..c0080ffb6effd2ee93bb2a8afe335d6394e29585 100644

--- a/base/metrics/statistics_recorder.h

+++ b/base/metrics/statistics_recorder.h

@@ -92,6 +92,8 @@ class BASE_EXPORT StatisticsRecorder {

friend class StatisticsRecorderTest;

FRIEND_TEST_ALL_PREFIXES(HistogramDeltaSerializationTest,

DeserializeHistogramAndAddSamples);

+ FRIEND_TEST_ALL_PREFIXES(HistogramSnapshotManagerTest,

+ PrepareDeltasHistogramFilter);

// The constructor just initializes static members. Usually client code should

// use Initialize to do this. But in test code, you can friend this class and