Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: base/metrics/histogram_snapshot_manager_unittest.cc

Issue 137623002: Let MetricsService know about some Android Activities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments on patch set 5 + a unit test Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/metrics/histogram_snapshot_manager_unittest.cc
diff --git a/base/metrics/histogram_snapshot_manager_unittest.cc b/base/metrics/histogram_snapshot_manager_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..de2a682680bbd917f47c9e46fcdcf35fe406f5ce
--- /dev/null
+++ b/base/metrics/histogram_snapshot_manager_unittest.cc
@@ -0,0 +1,106 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/metrics/histogram_snapshot_manager.h"
+
+#include <string>
+#include <vector>
+
+#include "base/metrics/histogram.h"
+#include "base/metrics/histogram_delta_serialization.h"
+#include "base/metrics/statistics_recorder.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace base {
+
+class HistogramFlattenerDeltaRecorder : public HistogramFlattener {
+ public:
+ virtual void RecordDelta(const HistogramBase& histogram,
+ const HistogramSamples& snapshot) {
+ recorded_delta_histogram_names_.push_back(histogram.histogram_name());
+ }
+
+ virtual void InconsistencyDetected(
+ HistogramBase::Inconsistency problem) OVERRIDE {
+ ASSERT_TRUE(false);
+ }
+
+ virtual void UniqueInconsistencyDetected(
+ HistogramBase::Inconsistency problem) OVERRIDE {
+ ASSERT_TRUE(false);
+ }
+
+ virtual void InconsistencyDetectedInLoggedCount(int amount) OVERRIDE {
+ ASSERT_TRUE(false);
+ }
+
+ std::vector<std::string> GetRecordedDeltaHistogramNames() {
+ return recorded_delta_histogram_names_;
+ }
+
+ void ClearRecordedData() { recorded_delta_histogram_names_.clear(); }
+
+ private:
+ std::vector<std::string> recorded_delta_histogram_names_;
+};
+
+TEST(HistogramSnapshotManagerTest, PrepareDeltasHistogramFilter) {
+ StatisticsRecorder statistics_recorder;
+ HistogramFlattenerDeltaRecorder histogram_flattener_delta_recorder;
+ HistogramSnapshotManager histogram_snapshot_manager(
+ &histogram_flattener_delta_recorder);
+ std::vector<std::string> recorded_delta_histogram_names;
+
+ // kNoFlags filter should record all histograms.
+ UMA_HISTOGRAM_ENUMERATION("UmaHistogram", 1, 2);
+ UMA_STABILITY_HISTOGRAM_ENUMERATION("UmaStabilityHistogram", 1, 2);
+ histogram_snapshot_manager.PrepareDeltas(HistogramBase::kNoFlags,
+ HistogramBase::kNoFlags);
+ recorded_delta_histogram_names =
+ histogram_flattener_delta_recorder.GetRecordedDeltaHistogramNames();
+ EXPECT_EQ((unsigned)2, recorded_delta_histogram_names.size());
+ EXPECT_EQ("UmaHistogram", recorded_delta_histogram_names[0]);
+ EXPECT_EQ("UmaStabilityHistogram", recorded_delta_histogram_names[1]);
+ histogram_flattener_delta_recorder.ClearRecordedData();
+
+ // Record histograms that have kUmaTargetedHistogramFlag.
+ UMA_HISTOGRAM_ENUMERATION("UmaHistogram", 1, 2);
+ UMA_STABILITY_HISTOGRAM_ENUMERATION("UmaStabilityHistogram", 1, 2);
+ histogram_snapshot_manager.PrepareDeltas(
+ HistogramBase::kNoFlags, HistogramBase::kUmaTargetedHistogramFlag);
+ recorded_delta_histogram_names =
+ histogram_flattener_delta_recorder.GetRecordedDeltaHistogramNames();
+ EXPECT_EQ((unsigned)2, recorded_delta_histogram_names.size());
+ EXPECT_EQ("UmaHistogram", recorded_delta_histogram_names[0]);
+ EXPECT_EQ("UmaStabilityHistogram", recorded_delta_histogram_names[1]);
+ histogram_flattener_delta_recorder.ClearRecordedData();
+
+ // Record only histograms that have kStabilityHistogramFlag.
+ UMA_HISTOGRAM_ENUMERATION("UmaHistogram", 1, 2);
+ UMA_STABILITY_HISTOGRAM_ENUMERATION("UmaStabilityHistogram", 1, 2);
+ histogram_snapshot_manager.PrepareDeltas(
+ HistogramBase::kNoFlags, HistogramBase::kStabilityHistogramFlag);
+ recorded_delta_histogram_names =
+ histogram_flattener_delta_recorder.GetRecordedDeltaHistogramNames();
+ EXPECT_EQ((unsigned)1, recorded_delta_histogram_names.size());
+ EXPECT_EQ("UmaStabilityHistogram", recorded_delta_histogram_names[0]);
+ histogram_flattener_delta_recorder.ClearRecordedData();
+
+ // Record only histograms that have both kUmaTargetedHistogramFlag and
+ // kStabilityHistogramFlag.
+ UMA_HISTOGRAM_ENUMERATION("UmaHistogram", 1, 2);
+ UMA_STABILITY_HISTOGRAM_ENUMERATION("UmaStabilityHistogram", 1, 2);
+ histogram_snapshot_manager.PrepareDeltas(
+ HistogramBase::kNoFlags,
+ static_cast<HistogramBase::Flags>(
+ HistogramBase::kUmaTargetedHistogramFlag |
+ HistogramBase::kStabilityHistogramFlag));
+ recorded_delta_histogram_names =
+ histogram_flattener_delta_recorder.GetRecordedDeltaHistogramNames();
+ EXPECT_EQ((unsigned)1, recorded_delta_histogram_names.size());
+ EXPECT_EQ("UmaStabilityHistogram", recorded_delta_histogram_names[0]);
+ histogram_flattener_delta_recorder.ClearRecordedData();
+}
+
+} // namespace base

Powered by Google App Engine
This is Rietveld 408576698