Chromium Code Reviews| Index: base/metrics/histogram_snapshot_manager.h |
| diff --git a/base/metrics/histogram_snapshot_manager.h b/base/metrics/histogram_snapshot_manager.h |
| index 3c7050859e3f92230a83a491a364585eed57db91..1d4fe002e5ae1edeea37c7241cddcfdb7f583aed 100644 |
| --- a/base/metrics/histogram_snapshot_manager.h |
| +++ b/base/metrics/histogram_snapshot_manager.h |
| @@ -29,9 +29,13 @@ class BASE_EXPORT HistogramSnapshotManager { |
| virtual ~HistogramSnapshotManager(); |
| // Snapshot all histograms, and ask |histogram_flattener_| to record the |
| - // delta. The arguments allow selecting only a subset of histograms for |
| - // recording, or to set a flag in each recorded histogram. |
| - void PrepareDeltas(HistogramBase::Flags flags_to_set, bool record_only_uma); |
| + // delta. |flags_to_set| is used to set flags for each histogram. |
| + // |flag_filter_to_record| is used to select histograms to be recorded. |
| + // Only histograms that have all the flags specified by the argument will be |
| + // chosen. If all histograms should to be recorded, set it to |
|
Ilya Sherman
2014/02/08 00:59:49
nit: "should to be" -> "should be"
Kibeom Kim (inactive)
2014/02/10 22:24:45
Done.
|
| + // Histogram::kNoFlags . |
|
Ilya Sherman
2014/02/08 00:59:49
nit: Spurious space before the period.
Kibeom Kim (inactive)
2014/02/10 22:24:45
Done.
|
| + void PrepareDeltas(HistogramBase::Flags flags_to_set, |
| + HistogramBase::Flags flag_filter_to_record); |
|
Ilya Sherman
2014/02/08 00:59:49
nit: "flag_filter_to_record" is pretty hard to mak
Kibeom Kim (inactive)
2014/02/10 22:24:45
Done. (thanks for the better naming!)
|
| private: |
| // Snapshot this histogram, and record the delta. |