Let MetricsService know about some Android Activities

base/metrics/histogram_snapshot_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_METRICS_HISTOGRAM_SNAPSHOT_MANAGER_H_
 #define BASE_METRICS_HISTOGRAM_SNAPSHOT_MANAGER_H_
 
 #include <map>
 #include <string>
 
@@ skipping 11 matching lines @@
 // in memory for an extended period of time, and are vulnerable to memory
 // corruption, this class also validates as much rendundancy as it can before
 // calling for the marginal change (a.k.a., delta) in a histogram to be
 // recorded.
 class BASE_EXPORT HistogramSnapshotManager {
  public:
   explicit HistogramSnapshotManager(HistogramFlattener* histogram_flattener);
   virtual ~HistogramSnapshotManager();
 
   // Snapshot all histograms, and ask |histogram_flattener_| to record the
-  // delta. The arguments allow selecting only a subset of histograms for
-  // recording, or to set a flag in each recorded histogram.
-  void PrepareDeltas(HistogramBase::Flags flags_to_set, bool record_only_uma);
+  // delta. |flags_to_set| is used to set flags for each histogram.
+  // |flag_filter_to_record| is used to select histograms to be recorded.
+  // Only histograms that have all the flags specified by the argument will be
+  // chosen. If all histograms should to be recorded, set it to

[Ilya Sherman, 2014/02/08 00:59:49]

nit: "should to be" -> "should be"

[Kibeom Kim (inactive), 2014/02/10 22:24:45]

Done.

+  // Histogram::kNoFlags .

[Ilya Sherman, 2014/02/08 00:59:49]

nit: Spurious space before the period.

[Kibeom Kim (inactive), 2014/02/10 22:24:45]

Done.

+  void PrepareDeltas(HistogramBase::Flags flags_to_set,
+                     HistogramBase::Flags flag_filter_to_record);

[Ilya Sherman, 2014/02/08 00:59:49]

nit: "flag_filter_to_record" is pretty hard to make sense of.  Perhaps something
more like "flags_required_for_recording", or maybe even something shorter like
"required_flags"?

[Kibeom Kim (inactive), 2014/02/10 22:24:45]

Done. (thanks for the better naming!)

 
  private:
   // Snapshot this histogram, and record the delta.
   void PrepareDelta(const HistogramBase& histogram);
 
   // Try to detect and fix count inconsistency of logged samples.
   void InspectLoggedSamplesInconsistency(
       const HistogramSamples& new_snapshot,
       HistogramSamples* logged_samples);
 
   // For histograms, track what we've already recorded (as a sample for
   // each histogram) so that we can record only the delta with the next log.
   std::map<std::string, HistogramSamples*> logged_samples_;
 
   // List of histograms found to be corrupt, and their problems.
   std::map<std::string, int> inconsistencies_;
 
   // |histogram_flattener_| handles the logistics of recording the histogram
   // deltas.
   HistogramFlattener* histogram_flattener_;  // Weak.
 
   DISALLOW_COPY_AND_ASSIGN(HistogramSnapshotManager);
 };
 
 }  // namespace base
 
 #endif  // BASE_METRICS_HISTOGRAM_SNAPSHOT_MANAGER_H_