Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issue 1376143003: Revert of Implement a site engagement score based on time-on-site. (Closed)

Created:
5 years, 2 months ago by phoglund_chromium
Modified:
5 years, 2 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement a site engagement score based on time-on-site. (patchset #20 id:400001 of https://codereview.chromium.org/1338603002/ ) Reason for revert: Appears to break SiteEngagementServiceBrowserTest.SimulateInput on at least Mac 10.10: see https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/3034. Original issue's description: > Implement a site engagement score based on time-on-site. > > Time spent on site is an important indicator of how important an origin > is to a user. This CL detects time on site by registering callbacks to > handle user input, using any mouse or keypress events as a proxy for > a user spending time on the site. Input events are checked for at > regular intervals, with site engagement updated if input has been > present in each interval. > > BUG=464234 > > Committed: https://crrev.com/f3226a4f280b20eb00024d724b9e70ec1edc2e33 > Cr-Commit-Position: refs/heads/master@{#351465} TBR=calamity@chromium.org,benwells@chromium.org,jdduke@chromium.org,dominickn@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=464234 Committed: https://crrev.com/4e4ecf3842360f00b08c34a08ff72c9ab20a137f Cr-Commit-Position: refs/heads/master@{#351511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -864 lines) Patch
M chrome/browser/engagement/site_engagement_eviction_policy_unittest.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M chrome/browser/engagement/site_engagement_helper.h View 2 chunks +4 lines, -73 lines 0 comments Download
M chrome/browser/engagement/site_engagement_helper.cc View 2 chunks +17 lines, -162 lines 0 comments Download
M chrome/browser/engagement/site_engagement_service.h View 4 chunks +8 lines, -20 lines 0 comments Download
M chrome/browser/engagement/site_engagement_service.cc View 4 chunks +26 lines, -36 lines 0 comments Download
D chrome/browser/engagement/site_engagement_service_browsertest.cc View 1 chunk +0 lines, -486 lines 0 comments Download
M chrome/browser/engagement/site_engagement_service_unittest.cc View 14 chunks +47 lines, -79 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
phoglund_chromium
Created Revert of Implement a site engagement score based on time-on-site.
5 years, 2 months ago (2015-09-30 07:43:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376143003/1
5 years, 2 months ago (2015-09-30 07:44:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 07:45:31 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 07:46:15 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e4ecf3842360f00b08c34a08ff72c9ab20a137f
Cr-Commit-Position: refs/heads/master@{#351511}

Powered by Google App Engine
This is Rietveld 408576698