Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1376023002: [Offline pages] Showing more than one row in saved offline filter (Closed)

Created:
5 years, 2 months ago by fgorski
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Showing more than one row in saved offline filter Saved offline filter view shows the size of offline copy below the title of the page, which prompts for spacing between the rows. Bug here is that resource storing dimensions was not properly converted to a number of pixels. Also, the size of spacing was too large (once it applied properly). BUG=536945 Committed: https://crrev.com/dcb8fa6715d1717c8eb75c8df88edd98cb5ae655 Cr-Commit-Position: refs/heads/master@{#351591}

Patch Set 1 #

Patch Set 2 : Updating row spacing in filter view to 16dp per UX recommendation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/android/java/res/values/dimens.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkRecyclerView.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
fgorski
kkimlabs@chromium.org: Please review changes in enhanced bookmarks aurimas@chromium.org: Please review changes in dimensions: Given this ...
5 years, 2 months ago (2015-09-29 20:32:56 UTC) #2
aurimas (slooooooooow)
chrome/android/java/res/values/dimens.xml LGTM
5 years, 2 months ago (2015-09-29 20:37:03 UTC) #3
Kibeom Kim (inactive)
lgtm (I guess I missed this in some code review sorry!)
5 years, 2 months ago (2015-09-29 21:09:49 UTC) #4
fgorski
Aurimas, per UX I am updating to 16dp (you were looped in) Kibeom, no worries... ...
5 years, 2 months ago (2015-09-30 16:51:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376023002/20001
5 years, 2 months ago (2015-09-30 16:57:20 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-30 17:46:15 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 17:47:01 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dcb8fa6715d1717c8eb75c8df88edd98cb5ae655
Cr-Commit-Position: refs/heads/master@{#351591}

Powered by Google App Engine
This is Rietveld 408576698