chrome/android/java/res/values/dimens.xml - Issue 1376023002: [Offline pages] Showing more than one row in saved offline filter

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/values/dimens.xml

Issue 1376023002: [Offline pages] Showing more than one row in saved offline filter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updating row spacing in filter view to 16dp per UX recommendation Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <resources>	6 <resources>

7 <!-- Connection info popup dimensions -->	7 <!-- Connection info popup dimensions -->

8 <dimen name="connection_info_padding_wide">24dp</dimen>	8 <dimen name="connection_info_padding_wide">24dp</dimen>

9 <dimen name="connection_info_padding_thin">16dp</dimen>	9 <dimen name="connection_info_padding_thin">16dp</dimen>

10	10

(...skipping 277 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
288	288

289 <!-- Favicon dimensions -->	289 <!-- Favicon dimensions -->

290 <dimen name="default_favicon_size">16dp</dimen>	290 <dimen name="default_favicon_size">16dp</dimen>

291	291

292 <!-- Media UI dimensions -->	292 <!-- Media UI dimensions -->

293 <!-- The media_session_icon_size is just big enough to make sure Android doe sn't discard the	293 <!-- The media_session_icon_size is just big enough to make sure Android doe sn't discard the

294 icon but otherwise, the icon is meant to be a flat color so it doesn't really matter. -->	294 icon but otherwise, the icon is meant to be a flat color so it doesn't really matter. -->

295 <dimen name="media_session_icon_size">48dp</dimen>	295 <dimen name="media_session_icon_size">48dp</dimen>

296	296

297 <!-- Offline pages dimensions -->	297 <!-- Offline pages dimensions -->

298 <dimen name="offline_page_item_vertical_spacing">40dp</dimen>	298 <dimen name="offline_page_item_vertical_spacing">16dp</dimen>

299 </resources>	299 </resources>

OLD	NEW